pleroma/pleroma-fe
2
2
Fork 6
Code Issues 347 Pull requests 25 Projects Releases Packages 1 Wiki Activity

updated registration errors #2516

Open
parallel588 wants to merge 4 commits from gitlab-mr-iid-1249 into develop
pull from: gitlab-mr-iid-1249
merge into: pleroma:develop
Conversation 4 Commits 4 Files changed 2 +14 -4
parallel588 commented 2020-10-11 13:49:12 +00:00
Member
Copy link

https://git.pleroma.social/pleroma/pleroma/-/issues/2205
pleroma/pleroma#6442

https://git.pleroma.social/pleroma/pleroma/-/issues/2205 https://git.pleroma.social/pleroma/pleroma/pulls/6442
hj commented 2020-11-01 17:48:37 +00:00
Owner
Copy link

This shows only one error. I.e. good captcha + invalid token shows "Invalid token", but bad captcha + invalid token doesn't show anything.

{"error":"{\"captcha\":[\"Invalid CAPTCHA (Missing parameter: captcha_solution)\"]}"}

{"error":"Invalid token"} <-- only this one gives an error message

{"error":"{\"captcha\":[\"Invalid CAPTCHA\"]}"}

This shows only one error. I.e. good captcha + invalid token shows "Invalid token", but bad captcha + invalid token doesn't show anything. `{"error":"{\"captcha\":[\"Invalid CAPTCHA (Missing parameter: captcha_solution)\"]}"}` `{"error":"Invalid token"}` <-- only this one gives an error message `{"error":"{\"captcha\":[\"Invalid CAPTCHA\"]}"}`
parallel588 commented 2020-11-02 14:38:31 +00:00
Author
Member
Copy link

hi @hj . Could you explain how I can re-produce you error?
do you have the Invalid token error for invite or this other error?

hi @hj . Could you explain how I can re-produce you error? do you have the `Invalid token` error for invite or this other error?
hj commented 2020-11-02 15:28:11 +00:00
Owner
Copy link

I just have instance with registrations locked, and I deliberately used expired token to cause an error. I will re-test it some more.

I just have instance with registrations locked, and I deliberately used expired token to cause an error. I will re-test it some more.
hj commented 2021-02-20 19:33:17 +00:00
Owner
Copy link

@parallel588 ping

@parallel588 ping
This pull request has changes conflicting with the target branch.
  • src/components/registration/registration.js
  • src/components/registration/registration.vue
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin gitlab-mr-iid-1249:gitlab-mr-iid-1249
git switch gitlab-mr-iid-1249

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch develop
git merge --no-ff gitlab-mr-iid-1249
git switch gitlab-mr-iid-1249
git rebase develop
git switch develop
git merge --ff-only gitlab-mr-iid-1249
git switch gitlab-mr-iid-1249
git rebase develop
git switch develop
git merge --no-ff gitlab-mr-iid-1249
git switch develop
git merge --squash gitlab-mr-iid-1249
git switch develop
git merge --ff-only gitlab-mr-iid-1249
git switch develop
git merge gitlab-mr-iid-1249
git push origin develop
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!2516
No description provided.