pleroma/pleroma-fe
0
0
Fork 0
Code Issues 343 Pull requests 27 Projects Releases Packages Wiki Activity

Draft: dailyAvgTimeframe #2966

Open
kraskaska wants to merge 2 commits from gitlab-mr-iid-1699 into develop
pull from: gitlab-mr-iid-1699
merge into: pleroma:develop
Conversation 2 Commits 2 Files changed 4 +30 -5
kraskaska commented 2022-12-17 17:09:17 +00:00
Member
Copy link

Changes

  • Added ability to change daily average timeframe (i.e. only count statuses that are less than week old)
    By default it will follow old behaviour (all time average of all statuses)
  • Added relevant config property:
    dailyAvgTimeframe - timeframe in days that daily average will count or 'old' to follow old behaviour

Current issues:

  • New behaviour only knows about loaded statuses
<!-- Feel free to submit merge requests that are work-in-progress, but mark them as Draft: or WIP:. Merge requests that have Draft or WIP status will not be merged and have less chances of being reviewed, but you can still ask people to take a look if you need advice. --> # Changes * Added ability to change daily average timeframe (i.e. only count statuses that are less than week old) By default it will follow old behaviour (all time average of all statuses) * Added relevant config property: dailyAvgTimeframe - timeframe in days that daily average will count or 'old' to follow old behaviour # Current issues: * New behaviour only knows about loaded statuses <!-- List what your merge request changes and how --> <!-- Try to not to break existing behavior, if your changes do break existing behavior make it configurable to toggle between old behavior and new. Which one should be default is up to discussion. --> <!-- If your merge request resolves some issue link it like so: "Closes #99999" --> <!-- If merge request adds some new feature that depends on backend: 1. Make sure it gracefully degrades if backend hasn't been updated to support the feature, we try to make PleromaFE compatible with older versions of BE so that people can still update frontend safely without updating backend since it's costly and much riskier. 2. Link related BE merge request here --> <!-- Screenshots are welcome -->
hj commented 2022-12-17 19:12:18 +00:00
Owner
Copy link

i think this average calculation should be moved to backend which does know about all posts and can pre-calculate it.

i think this average calculation should be moved to backend which does know about all posts and can pre-calculate it.
kraskaska commented 2022-12-18 05:01:21 +00:00
Author
Member
Copy link

gonna take a look at backend then

gonna take a look at backend then
This pull request has changes conflicting with the target branch.
  • public/static/config.json
  • src/boot/after_store.js
  • src/components/user_card/user_card.js
  • src/modules/instance.js
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin gitlab-mr-iid-1699:gitlab-mr-iid-1699
git switch gitlab-mr-iid-1699

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch develop
git merge --no-ff gitlab-mr-iid-1699
git switch gitlab-mr-iid-1699
git rebase develop
git switch develop
git merge --ff-only gitlab-mr-iid-1699
git switch gitlab-mr-iid-1699
git rebase develop
git switch develop
git merge --no-ff gitlab-mr-iid-1699
git switch develop
git merge --squash gitlab-mr-iid-1699
git switch develop
git merge --ff-only gitlab-mr-iid-1699
git switch develop
git merge gitlab-mr-iid-1699
git push origin develop
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!2966
No description provided.