pleroma/pleroma-fe
3
2
Fork 5
Code Issues 345 Pull requests 26 Projects Releases Packages Wiki Activity

Use stylelint #3019

Closed
tusooa wants to merge 0 commits from gitlab-mr-iid-1752 into develop
pull from: gitlab-mr-iid-1752
merge into: pleroma:develop
Conversation 8 Commits - Files changed -
tusooa commented 2023-01-09 18:04:55 +00:00
Owner
Copy link

Close #1173 #857

Changes

  • Use stylelint
  • Something to debate: no-longhand may reduce readability in some points, like border-radius or margin, because the order of the properties are not easily memorable.
Close #1173 #857 <!-- Feel free to submit merge requests that are work-in-progress, but mark them as Draft: or WIP:. Merge requests that have Draft or WIP status will not be merged and have less chances of being reviewed, but you can still ask people to take a look if you need advice. --> # Changes * Use stylelint * Something to debate: no-longhand may reduce readability in some points, like border-radius or margin, because the order of the properties are not easily memorable. * <!-- List what your merge request changes and how --> <!-- Try to not to break existing behavior, if your changes do break existing behavior make it configurable to toggle between old behavior and new. Which one should be default is up to discussion. --> <!-- If your merge request resolves some issue link it like so: "Closes #99999" --> <!-- If merge request adds some new feature that depends on backend: 1. Make sure it gracefully degrades if backend hasn't been updated to support the feature, we try to make PleromaFE compatible with older versions of BE so that people can still update frontend safely without updating backend since it's costly and much riskier. 2. Link related BE merge request here --> <!-- Screenshots are welcome -->
tusooa commented 2023-01-09 19:03:25 +00:00
Author
Owner
Copy link

disabled rscss/class-format because of https://github.com/rstacruz/stylelint-rscss/issues/13

disabled rscss/class-format because of https://github.com/rstacruz/stylelint-rscss/issues/13
hj commented 2023-01-09 21:08:32 +00:00
Owner
Copy link

overall looks fine to me, we need to find better alternative to RSCSS since it's not widely supported, there's SMACSS that seems to be more popular

no-longhand

i don't really have an opinion, as long as it's fixable, some things are a bit easier to memorize like border and border-width so those could be made exceptions

overall looks fine to me, we need to find better alternative to RSCSS since it's not widely supported, there's SMACSS that seems to be more popular >no-longhand i don't really have an opinion, as long as it's fixable, some things are a bit easier to memorize like `border` and `border-width` so those could be made exceptions
tusooa commented 2023-01-09 22:14:54 +00:00
Author
Owner
Copy link

check

check
tusooa commented 2023-01-10 01:49:42 +00:00
Author
Owner
Copy link

gonna review the code once more tomorrow to prevent accidental changes to "intended" places just like the one above

gonna review the code once more tomorrow to prevent accidental changes to "intended" places just like the one above
tusooa commented 2023-01-13 05:16:56 +00:00
Author
Owner
Copy link

check

check
tusooa commented 2023-01-13 05:19:37 +00:00
Author
Owner
Copy link

check

check
tusooa commented 2023-01-13 05:26:49 +00:00
Author
Owner
Copy link

autoprefixer will prefix that

autoprefixer will prefix that
tusooa commented 2023-01-13 05:45:08 +00:00
Author
Owner
Copy link

i guess it's ready

i guess it's ready

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!3019
No description provided.