Dialog modal improvements #3147

Closed
feld wants to merge 3 commits from gitlab-mr-iid-1880 into develop
Owner

Changes

  • text-align
  • footer buttons centered
  • english i8n shorter text

image

Closes #1289

# Changes * text-align * footer buttons centered * english i8n shorter text ![image](/attachments/66033d6f-0d41-4eb6-8e8e-87591e95055a) Closes #1289
Owner

make a new key so that translators know meaning got changed

make a new key so that translators know meaning got changed
Owner
no, most platforms have them on the right. https://uxmovement.com/buttons/why-ok-buttons-in-dialog-boxes-work-best-on-the-right/
Owner

this is a very dirty fix, and it doesn't solve the underlying problem, text overflow can still happen in other lanugages.

this is a very dirty fix, and it doesn't solve the underlying problem, text overflow can still happen in other lanugages.
Owner

I don't think this is necessary

I don't think this is necessary
Owner

Probably not, the meaning/functionality of this message is still the same. Just the text is shorter -- the trouble of the text being too long only applies to the English version, not necessarily to other language versions.

Probably not, the meaning/functionality of this message is still the same. Just the text is shorter -- the trouble of the text being too long only applies to the English version, not necessarily to other language versions.
Owner

superceded by #3230

superceded by #3230

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!3147
No description provided.