pleroma/pleroma-fe
0
0
Fork 0
Code Issues 343 Pull requests 27 Projects Releases Packages Wiki Activity

Admin emoji pack settings #3153

Closed
vaartis wants to merge 0 commits from gitlab-mr-iid-1886 into develop
pull from: gitlab-mr-iid-1886
merge into: pleroma:develop
Conversation 25 Commits - Files changed -
vaartis commented 2024-01-07 11:43:07 +00:00
Member
Copy link

Changes

  • Added emoji pack management to the pleroma-fe admin panel
    • Creating and deleting packs
    • Viewing and downloading remote packs
    • Editing pack metadata, when changed it shows the wrench icon
    • Uploading and editing individual files. Files that are edited but not saved are highlighted.
  • Added a button to reload and import emojis from the filesystem
  • Not directly emoji related, but also made frontend management not break completely if there is no config in DB
  • New localization included, hopefully I didn't miss any

Currently it loads pack information every time it's mounted, not sure where else to put that. Could maybe somehow be unified with the emoji list used for posting? That can be done later, though.

Does not have any pagination support for packs, so first 25 packs only both locally and remotely. Something that can also be dealt with later, I think.
Added pagination. There's still a way to paginate emojis themselves but that requires a significant amount of work to make usable I think.

Old admin fe also had support for downloading emojis from URLs, which would be useful but can probably also be added later.

Local pack

image

Remote pack

image

# Changes * Added emoji pack management to the pleroma-fe admin panel * Creating and deleting packs * Viewing and downloading remote packs * Editing pack metadata, when changed it shows the wrench icon * Uploading and editing individual files. Files that are edited but not saved are highlighted. * Added a button to reload and import emojis from the filesystem * *Not directly emoji related, but also* made frontend management not break completely if there is no config in DB * New localization included, hopefully I didn't miss any Currently it loads pack information every time it's mounted, not sure where else to put that. Could maybe somehow be unified with the emoji list used for posting? That can be done later, though. ~~Does not have any pagination support for packs, so first 25 packs only both locally and remotely. Something that can also be dealt with later, I think.~~ Added pagination. There's still a way to paginate _emojis themselves_ but that requires a significant amount of work to make usable I think. Old admin fe also had support for downloading emojis from URLs, which would be useful but can probably also be added later. Local pack ![image](/attachments/28f8a96b-c924-40df-bb33-b98f8190689f) Remote pack ![image](/attachments/05964ae3-7f20-48aa-a293-b6aca4779b78) <!-- List what your merge request changes and how --> <!-- Try to not to break existing behavior, if your changes do break existing behavior make it configurable to toggle between old behavior and new. Which one should be default is up to discussion. --> <!-- If your merge request resolves some issue link it like so: "Closes #99999" --> <!-- If merge request adds some new feature that depends on backend: 1. Make sure it gracefully degrades if backend hasn't been updated to support the feature, we try to make PleromaFE compatible with older versions of BE so that people can still update frontend safely without updating backend since it's costly and much riskier. 2. Link related BE merge request here --> <!-- Screenshots are welcome -->
image.png
132 KiB
image.png
44 KiB
vaartis commented 2024-01-07 12:27:11 +00:00
Author
Member
Copy link

Okay, BE needs some changes to work with akkoma (pleroma/pleroma#7405). Not a big deal, but still.
Might also implelent pagination after all because at the very least outerheaven has more than 25 packs.

Okay, BE needs some changes to work with akkoma (https://git.pleroma.social/pleroma/pleroma/pulls/7405). Not a big deal, but still. Might also implelent pagination after all because at the very least outerheaven has more than 25 packs.
hj commented 2024-01-08 16:07:55 +00:00
Owner
Copy link

Clicking emoji in the grid gives them a highlight that never goes away
image

Classname seem to indicate that it's meant for unsaved changes but

  • It's not obvious that it is, having an alert that says "unsaved changes" or something would improve situation a bit
  • Clicking "save" doesn't reset this state
  • No way to revert changes
Clicking emoji in the grid gives them a highlight that never goes away ![image](/attachments/47553540-cce9-4b6e-86e6-f02ceecd47ec) Classname seem to indicate that it's meant for unsaved changes but - It's not obvious that it is, having an alert that says "unsaved changes" or something would improve situation a bit - Clicking "save" doesn't reset this state - No way to revert changes
image.png
54 KiB
hj commented 2024-01-08 16:18:09 +00:00
Owner
Copy link

Layout could use some improvements
image

Ideally save/reset should be integrated into reset/apply all buttons but we can do it later.

Layout could use some improvements ![image](/attachments/4bb0c880-721d-462a-b916-2cf9da748e79) Ideally save/reset should be integrated into reset/apply all buttons but we can do it later.
image.png
141 KiB
hj commented 2024-01-08 16:57:00 +00:00
Owner
Copy link

Emoji editing popover also needs improvements

  • input fields should have labels
  • fields should be all vertically stacked
  • should include the image of the emoji being edited/uploaded.
  • probably should be a modal since it's way too easy to accidentally close the popover while editing, losing your changes
  • being able to update the emoji file by uploading it would be very nice
Emoji editing popover also needs improvements - input fields should have labels - fields should be all vertically stacked - should include the image of the emoji being edited/uploaded. - probably should be a modal since it's way too easy to accidentally close the popover while editing, losing your changes - being able to update the emoji file by uploading it would be very nice
tusooa commented 2024-01-13 23:06:59 +00:00
Owner
Copy link

Form elements must be labelled.

Form elements must be labelled.
tusooa commented 2024-01-13 23:07:00 +00:00
Owner
Copy link

There is a bit of lag when switching to a new emoji pack that has not been loaded. I think there should be some kind of loading indicator.

There is a bit of lag when switching to a new emoji pack that has not been loaded. I think there should be some kind of loading indicator.
tusooa commented 2024-01-13 23:07:00 +00:00
Owner
Copy link

This should be a <label> that contains the input element. Same for the next few entries.

This should be a `<label>` that contains the input element. Same for the next few entries.
tusooa commented 2024-01-13 23:07:00 +00:00
Owner
Copy link

This no longer indicates that the entry is different from default, but rather it has been changed from the old value. We can make a prop in ModifiedIndicator for it to display different messages based on this.

This no longer indicates that the entry is different from default, but rather it has been changed from the old value. We can make a prop in ModifiedIndicator for it to display different messages based on this.
tusooa commented 2024-01-13 23:07:00 +00:00
Owner
Copy link

There does not seem to be a "Reset" button to clear the locally-modified pack settings.

There does not seem to be a "Reset" button to clear the locally-modified pack settings.
tusooa commented 2024-01-13 23:07:00 +00:00
Owner
Copy link

Form elements must have text labels.

Form elements must have text labels.
tusooa commented 2024-01-13 23:07:00 +00:00
Owner
Copy link

There is no way to switch from remote packs back to local packs currently.

There is no way to switch from remote packs back to local packs currently.
hj commented 2024-01-18 12:50:16 +00:00
Owner
Copy link

the headers should be all a level deeper (h2 -> h3, h3 -> h4) but that's minor. Layout looks good now.

the headers should be all a level deeper (h2 -> h3, h3 -> h4) but that's minor. Layout looks good now.
hj commented 2024-01-18 12:52:18 +00:00
Owner
Copy link

resolved

resolved
hj commented 2024-01-18 13:06:11 +00:00
Owner
Copy link
        <h3>{{ $t('admin_dash.emoji.global_actions') }}</h3>
```suggestion:-0+0 <h3>{{ $t('admin_dash.emoji.global_actions') }}</h3> ```
hj commented 2024-01-18 13:06:11 +00:00
Owner
Copy link
        <h3>{{ $t('admin_dash.emoji.emoji_packs') }}</h3>
```suggestion:-0+0 <h3>{{ $t('admin_dash.emoji.emoji_packs') }}</h3> ```
hj commented 2024-01-18 13:06:11 +00:00
Owner
Copy link
          <h4>
            {{ $t('admin_dash.emoji.files') }}

            <ModifiedIndicator v-if="pack"
              :changed="editedParts[packName] && Object.keys(editedParts[packName]).length > 0"
              message-key="admin_dash.emoji.emoji_changed"/>
          </h4>
```suggestion:-6+0 <h4> {{ $t('admin_dash.emoji.files') }} <ModifiedIndicator v-if="pack" :changed="editedParts[packName] && Object.keys(editedParts[packName]).length > 0" message-key="admin_dash.emoji.emoji_changed"/> </h4> ```
hj commented 2024-01-18 13:06:12 +00:00
Owner
Copy link

this.$refs.addEmojiPopover is undefined, looks like a missing ref.

probably should hide popover once the upload is done (or failed, display error message then)

also would really love to see it unified with edit emoji popover not only for sake of code simplifiation but also to be able to update file of existing emoji

`this.$refs.addEmojiPopover` is undefined, looks like a missing ref. probably should hide popover once the upload is done (or failed, display error message then) also would really love to see it unified with edit emoji popover not only for sake of code simplifiation but also to be able to update file of existing emoji
vaartis commented 2024-01-19 20:17:33 +00:00
Author
Member
Copy link

I don't think this specific one needs a label, as it's right below "Emoji packs" now

I don't think this specific one needs a label, as it's right below "Emoji packs" now
vaartis commented 2024-01-19 20:28:53 +00:00
Author
Member
Copy link

Remote packs get added to the list, you just choose from the list. No need to switch anywhere.

Remote packs get added to the list, you just choose from the list. No need to switch anywhere.
hj commented 2024-01-22 18:45:09 +00:00
Owner
Copy link

injecting emojiAddr is good but for displayError there should be an emit instead IMO, or given that what displayError actually does you can just use this.$store.dispatch('pushGlobalNotice',...) directly instead

injecting `emojiAddr` is good but for `displayError` there should be an emit instead IMO, or given that what `displayError` actually does you can just use `this.$store.dispatch('pushGlobalNotice',...)` directly instead
hj commented 2024-01-22 18:45:09 +00:00
Owner
Copy link

there should also be an emits for events this component can emit

there should also be an `emits` for events this component can emit
hj commented 2024-01-22 18:51:49 +00:00
Owner
Copy link

"Edit pack" would be nice nonetheless imo

"Edit pack" would be nice nonetheless imo
hj commented 2024-01-22 20:20:05 +00:00
Owner
Copy link
  emits: ['updatePackFiles', 'displayError'],
```suggestion:-0+0 emits: ['updatePackFiles', 'displayError'], ```
hj commented 2024-01-24 21:52:19 +00:00
Owner
Copy link

can't edit an emoji, save button just doesn't become active.

can't edit an emoji, save button just doesn't become active.
hj commented 2024-01-24 21:53:05 +00:00
Owner
Copy link

if you change shortcode of an emoji (but don't save it), delete button breaks as it tries to delete new shortcode which doesn't (yet) exist

if you change shortcode of an emoji (but don't save it), delete button breaks as it tries to delete new shortcode which doesn't (yet) exist

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!3153
No description provided.