pleroma/pleroma-fe
0
0
Fork 0
Code Issues 343 Pull requests 27 Projects Releases Packages Wiki Activity

Show real vote counts #3363

Open
feld wants to merge 1 commit from gitlab-mr-iid-2096 into develop
pull from: gitlab-mr-iid-2096
merge into: pleroma:develop
Conversation 7 Commits 1 Files changed 26 +12 -40
feld commented 2025-03-19 18:19:05 +00:00
Owner
Copy link

Polls have always shown an inaccurate vote count because it is trying to show the count of voters for your local instance. We have had the real vote counts for a long time now and it gets refreshed periodically until the poll closes and then a final vote count is fetched from the origin.

Fixing this makes the poll information more useful to users especially on smaller instances.

image{width=618 height=294}

Polls have always shown an inaccurate vote count because it is trying to show the count of voters for your local instance. We have had the real vote counts for a long time now and it gets refreshed periodically until the poll closes and then a final vote count is fetched from the origin. Fixing this makes the poll information more useful to users especially on smaller instances. ![image](/attachments/2a9389c5-2d7b-41d3-b414-fdaee7e6d0b7){width=618 height=294}
image.png
120 KiB
hj commented 2025-03-19 19:33:10 +00:00
Owner
Copy link

So we don't have the people vote counts? I'm a bit confused with i18n removals

So we don't have the people vote counts? I'm a bit confused with i18n removals
feld commented 2025-03-19 19:34:55 +00:00
Author
Owner
Copy link

Displaying the count of local users who voted is not a useful metric

Displaying the count of local users who voted is not a useful metric
hj commented 2025-03-19 19:37:14 +00:00
Owner
Copy link

I thought it wasn't about local users but about votes (single-option polls) vs people voted (multi-option polls)

I thought it wasn't about local users but about votes (single-option polls) vs people voted (multi-option polls)
feld commented 2025-03-19 19:40:49 +00:00
Author
Owner
Copy link

If that was the intention it has always been broken because for single-option polls it has only shown the number of local users who voted.

If that was the intention it has always been broken because for single-option polls it has only shown the number of local users who voted.
feld commented 2025-03-19 19:59:00 +00:00
Author
Owner
Copy link

I just checked on a remote multiple-choice poll and it says "94 votes" which matches the amount when adding up each poll option.

The data for the object says: "voters" => [] so we don't have any voters to count.

The problem is that we receive no data that can indicate to us how many poll options each voter selected.

Now it's down to a language game: in a multiple choice poll, if you select two options is it really "two votes"? Or perhaps "Two votes, but one submission/response"?

We were definitely making an assumption that doesn't match the data we have access to in the backend right now. Is it possible that behavior was different back in the OStatus days?

I just checked on a remote multiple-choice poll and it says "94 votes" which matches the amount when adding up each poll option. The data for the object says: `"voters" => []` so we don't have any voters to count. The problem is that we receive no data that can indicate to us how many poll options each voter selected. Now it's down to a language game: in a multiple choice poll, if you select two options is it really "two votes"? Or perhaps "Two votes, but one submission/response"? We were definitely making an assumption that doesn't match the data we have access to in the backend right now. Is it possible that behavior was different back in the OStatus days?
hj commented 2025-03-19 20:30:55 +00:00
Owner
Copy link

i don't think we had polls in OStatus days

i don't think we had polls in OStatus days
hj commented 2025-03-20 07:55:54 +00:00
Owner
Copy link

So basically we don't and can't know number of voters, just number of votes? I guess it's ok to remove that counter there, but we should also do it for backend.

So basically we don't and can't know number of voters, just number of votes? I guess it's ok to remove that counter there, but we should also do it for backend.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin gitlab-mr-iid-2096:gitlab-mr-iid-2096
git switch gitlab-mr-iid-2096

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch develop
git merge --no-ff gitlab-mr-iid-2096
git switch gitlab-mr-iid-2096
git rebase develop
git switch develop
git merge --ff-only gitlab-mr-iid-2096
git switch gitlab-mr-iid-2096
git rebase develop
git switch develop
git merge --no-ff gitlab-mr-iid-2096
git switch develop
git merge --squash gitlab-mr-iid-2096
git switch develop
git merge --ff-only gitlab-mr-iid-2096
git switch develop
git merge gitlab-mr-iid-2096
git push origin develop
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!3363
No description provided.