pleroma/pleroma-fe
2
2
Fork 3
Code Issues 344 Pull requests 33 Projects Releases Packages Wiki Activity

Fix HTML attribute parsing for escaped quotes #3476

Open
mkljczk wants to merge 1 commit from mkljczk/pleroma-fe:attrs-parsing-fix into develop
pull from: mkljczk/pleroma-fe:attrs-parsing-fix
merge into: pleroma:develop
Conversation 0 Commits 1 Files changed 2 +2 -1
mkljczk commented 2026-02-16 13:08:32 +00:00
Owner
Copy link

I was investigating a bug in akkoma-fe that didn't occur in pleroma-fe and found out the tag attrs regex (that should have never existed) doesn't handle escaped quotes properly (at least here it doesn't cause crashes)

I was investigating a bug in akkoma-fe that didn't occur in pleroma-fe and found out the tag attrs regex (that should have never existed) doesn't handle escaped quotes properly (at least here it doesn't cause crashes)
Signed-off-by: nicole mikołajczyk <git@mkljczk.pl>
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u attrs-parsing-fix:mkljczk-attrs-parsing-fix
git switch mkljczk-attrs-parsing-fix

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch develop
git merge --no-ff mkljczk-attrs-parsing-fix
git switch mkljczk-attrs-parsing-fix
git rebase develop
git switch develop
git merge --ff-only mkljczk-attrs-parsing-fix
git switch mkljczk-attrs-parsing-fix
git rebase develop
git switch develop
git merge --no-ff mkljczk-attrs-parsing-fix
git switch develop
git merge --squash mkljczk-attrs-parsing-fix
git switch develop
git merge --ff-only mkljczk-attrs-parsing-fix
git switch develop
git merge mkljczk-attrs-parsing-fix
git push origin develop
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!3476
No description provided.