pleroma/pleroma-fe
Watch
2
2
Fork
You've already forked pleroma-fe
 10
Code Issues 351 Pull requests 26 Projects Releases 5 Packages 1 Wiki Activity

Fix avatar change attempt resulting in error due to missing canvas element ref #3563

Open
iamtakingiteasy wants to merge 1 commit from iamtakingiteasy/pleroma-fe:fix-avatar-change-missing-canvas-ref into develop
pull from: iamtakingiteasy/pleroma-fe:fix-avatar-change-missing-canvas-ref
merge into: pleroma:develop
Conversation 0 Commits 1 Files changed 2 +5
iamtakingiteasy commented 2026-08-22 11:56:17 +00:00
Member
Copy link

Checklist

  • Adding a changelog: In the changelog.d directory, create a file named <code>.<type>.

For the first few update calls, canvas element ref is not populated and results in null dereference, this MR adds checks for that.

### Checklist - [x] Adding a changelog: In the `changelog.d` directory, create a file named `<code>.<type>`. For the first few update calls, canvas element ref is not populated and results in null dereference, this MR adds checks for that. <!-- `<code>` can be anything, but we recommend using a more or less unique identifier to avoid collisions, such as the branch name. `<type>` can be `add`, `change`, `remove`, `fix`, `security` or `skip`. `skip` is only used if there is no user-visible change in the MR (for example, only editing comments in the code). Otherwise, choose a type that corresponds to your change. In the file, write the changelog entry. For example, if an MR adds group functionality, we can create a file named `group.add` and write `Add group functionality` in it. If one changelog entry is not enough, you may add more. But that might mean you can split it into two MRs. Only use more than one changelog entry if you really need to (for example, when one change in the code fix two different bugs, or when refactoring). -->
fix avatar change attempt resulting in error due to missing canvas element ref
Some checks are pending
ci/woodpecker/pr/build Pipeline is pending approval
Details
ci/woodpecker/pr/changelog Pipeline is pending approval
Details
ci/woodpecker/pr/lint Pipeline is pending approval
Details
ci/woodpecker/pr/test-e2e Pipeline is pending approval
Details
ci/woodpecker/pr/test Pipeline is pending approval
Details
14bafa04c6
Some checks are pending
ci/woodpecker/pr/build Pipeline is pending approval
Details
ci/woodpecker/pr/changelog Pipeline is pending approval
Details
ci/woodpecker/pr/lint Pipeline is pending approval
Details
ci/woodpecker/pr/test-e2e Pipeline is pending approval
Details
ci/woodpecker/pr/test Pipeline is pending approval
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix-avatar-change-missing-canvas-ref:iamtakingiteasy-fix-avatar-change-missing-canvas-ref
git switch iamtakingiteasy-fix-avatar-change-missing-canvas-ref

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch develop
git merge --no-ff iamtakingiteasy-fix-avatar-change-missing-canvas-ref
git switch iamtakingiteasy-fix-avatar-change-missing-canvas-ref
git rebase develop
git switch develop
git merge --ff-only iamtakingiteasy-fix-avatar-change-missing-canvas-ref
git switch iamtakingiteasy-fix-avatar-change-missing-canvas-ref
git rebase develop
git switch develop
git merge --no-ff iamtakingiteasy-fix-avatar-change-missing-canvas-ref
git switch develop
git merge --squash iamtakingiteasy-fix-avatar-change-missing-canvas-ref
git switch develop
git merge --ff-only iamtakingiteasy-fix-avatar-change-missing-canvas-ref
git switch develop
git merge iamtakingiteasy-fix-avatar-change-missing-canvas-ref
git push origin develop
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!3563
No description provided.