pleroma/pleroma-fe
pleroma/pleroma-fe
Watch
2
2
Fork
You've already forked pleroma-fe
 12
Code Issues 350 Pull requests 28 Projects Releases 5 Packages 1 Wiki Activity

Poll set to days is posted with minutes #3585

Open
lambadalambda wants to merge 1 commit from fix/poll-expiry-unit into develop
pull from: fix/poll-expiry-unit
merge into: pleroma:develop
Conversation 1 Commits 1 Files changed 4 +71 -22
lambadalambda commented 2026-10-14 14:47:31 +00:00
Owner
Copy link

A poll set to 1 day ended after 1 minute. The unit Select had @change="expiryAmountChange" next to its v-model; that handler ran in the same tick and emitted {...modelValue, expiryAmount} from the stale prop, which put expiryUnit back to minutes. The native select kept showing days, so nothing looked wrong. expiryAmountChange also emitted twice (min, then max) from the same stale value.

The unit setter now emits the unit together with the amount clamped for it, and the amount field clamps the value from its own event. Tests mount the form inside a parent that holds the v-model, as the post form does; both fail on develop.

A poll set to 1 day ended after 1 minute. The unit `Select` had `@change="expiryAmountChange"` next to its v-model; that handler ran in the same tick and emitted `{...modelValue, expiryAmount}` from the stale prop, which put `expiryUnit` back to minutes. The native select kept showing days, so nothing looked wrong. `expiryAmountChange` also emitted twice (min, then max) from the same stale value. The unit setter now emits the unit together with the amount clamped for it, and the amount field clamps the value from its own event. Tests mount the form inside a parent that holds the v-model, as the post form does; both fail on develop.
fix(poll): a poll set to days is posted with days, not minutes
All checks were successful
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/changelog Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/test-e2e Pipeline was successful
Details
02d456bdc3
 
The unit select's change handler emitted the amount from the form's stale
modelValue prop, which put the unit back to minutes while the select still
showed days. The unit setter now emits the unit and its clamped amount in one
update, and the amount is clamped from the field's own value.
hj approved these changes 2026-10-14 16:02:20 +00:00
All checks were successful
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/changelog Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/test-e2e Pipeline was successful
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/poll-expiry-unit:fix/poll-expiry-unit
git switch fix/poll-expiry-unit

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch develop
git merge --no-ff fix/poll-expiry-unit
git switch fix/poll-expiry-unit
git rebase develop
git switch develop
git merge --ff-only fix/poll-expiry-unit
git switch fix/poll-expiry-unit
git rebase develop
git switch develop
git merge --no-ff fix/poll-expiry-unit
git switch develop
git merge --squash fix/poll-expiry-unit
git switch develop
git merge --ff-only fix/poll-expiry-unit
git switch develop
git merge fix/poll-expiry-unit
git push origin develop
Sign in to join this conversation.
Reviewers
No reviewers
hj
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!3585
No description provided.