pleroma/pleroma-fe
pleroma/pleroma-fe
Watch
2
2
Fork
You've already forked pleroma-fe
 13
Code Issues 349 Pull requests 22 Projects Releases 5 Packages 1 Wiki Activity

User media management, FE part #3603

Open
vaartis wants to merge 11 commits from media-management into develop
pull from: media-management
merge into: pleroma:develop
Conversation 2 Commits 11 Files changed 11 +338 -2
vaartis commented 2026-11-04 17:15:43 +00:00
Member
Copy link

Checklist

  • Adding a changelog: In the changelog.d directory, create a file named <code>.<type>.

Required BE PR: pleroma/pleroma#8058

This implements the new endpoints for managing user's uploaded media:

  • Lists user's uploaded media with some information about it
  • Allows the user to check in which posts this attachment was used and whether there are duplicate files on the server
  • Allows the user to delete the attachment from the server, provided it is not used in any post

Issues:

  • It ain't pretty
  • I couldn't figure out how to make the spinner look good for the Duplicates section
  • "Used in" is just a list of links to posts

Screenshots:
image
image

### Checklist - [x] Adding a changelog: In the `changelog.d` directory, create a file named `<code>.<type>`. Required BE PR: pleroma/pleroma#8058 This implements the new endpoints for managing user's uploaded media: - Lists user's uploaded media with some information about it - Allows the user to check in which posts this attachment was used and whether there are duplicate files on the server - Allows the user to delete the attachment from the server, provided it is not used in any post Issues: - It ain't pretty - I couldn't figure out how to make the spinner look good for the Duplicates section - "Used in" is just a list of links to posts Screenshots: ![image](/attachments/f3151dcc-d233-4dfa-9036-c840ff968390) ![image](/attachments/fed63107-307a-460a-904a-92aac6c171ec)
image.png
377 KiB
image.png
83 KiB 
Still missing at least pagination
Backend now gives an attachment-shaped object, so it can be used with
the attachment component
Changelog
Some checks failed
ci/woodpecker/pr/test-e2e Pipeline is pending
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/changelog Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was canceled
Details
1c4e7ab12c
Only refresh media if management is available
All checks were successful
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/changelog Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/test-e2e Pipeline was successful
Details
1aa1e0a242
hj requested changes 2026-11-05 15:04:23 +00:00
src/components/settings_modal/tabs/uploaded_media_tab.vue Outdated
@ -0,0 +11,4 @@
<button class="btn button-default" @click="refreshMedia()">{{ $t('settings.uploaded_media.refresh') }}</button>
<div>
<div class="media-entry" v-for="media in knownMedia">
hj commented 2026-11-05 14:58:05 +00:00
Member
Copy link

needs an id attribute

needs an `id` attribute
hj commented 2026-11-05 15:19:36 +00:00
Member
Copy link

i meant key, sorry

i meant `key`, sorry
vaartis marked this conversation as resolved
src/components/settings_modal/tabs/uploaded_media_tab.vue Outdated
@ -0,0 +55,4 @@
<li>
<h4>{{$t('settings.uploaded_media.used_in')}}</h4>
<ul v-if="media.usage" class="used-in-objects-list">
<li v-for="obj in media.usage.objects">
hj commented 2026-11-05 14:59:16 +00:00
Member
Copy link

also needs a key

also needs a `key`
vaartis marked this conversation as resolved
src/components/settings_modal/tabs/uploaded_media_tab.vue Outdated
@ -0,0 +107,4 @@
</div>
</template>
<script>
hj commented 2026-11-05 15:00:42 +00:00
Member
Copy link

please move js and css into separate files

please move js and css into separate files
vaartis marked this conversation as resolved
src/components/settings_modal/tabs/uploaded_media_tab.vue Outdated
@ -0,0 +157,4 @@
: 'settings.uploaded_media.delete_error',
level: result ? 'success' : 'error',
})
this.deleteModalVisible = false
hj commented 2026-11-05 15:01:37 +00:00
Member
Copy link

i would put this into .finally()

i would put this into `.finally()`
vaartis marked this conversation as resolved
src/components/settings_modal/tabs/uploaded_media_tab.vue Outdated
@ -0,0 +154,4 @@
useInterfaceStore().pushGlobalNotice({
messageKey: result
? 'settings.uploaded_media.delete_success'
: 'settings.uploaded_media.delete_error',
hj commented 2026-11-05 15:02:26 +00:00
Member
Copy link

wouldn't failures just end up in .catch?

wouldn't failures just end up in `.catch`?
vaartis marked this conversation as resolved
src/components/settings_modal/tabs/uploaded_media_tab.vue Outdated
@ -0,0 +200,4 @@
},
computed: {
managementAvailable() {
return useInstanceCapabilitiesStore().mediaManagementAvailable
hj commented 2026-11-05 15:03:54 +00:00
Member
Copy link

i would use pinia's mapState

i would use pinia's `mapState`
vaartis marked this conversation as resolved
hj commented 2026-11-05 15:04:47 +00:00
Member
Copy link

Overall looks good, just have a few nitpicks

Overall looks good, just have a few nitpicks
Separate JS and CSS and address issues from the PR
Some checks failed
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/changelog Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline failed
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/test-e2e Pipeline was successful
Details
a50f4e4dad
Lint
All checks were successful
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/changelog Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/test-e2e Pipeline was successful
Details
14860d1dd3
Update to use new endpoint that supports throttling
All checks were successful
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/changelog Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/test-e2e Pipeline was successful
Details
8fd9e66471
All checks were successful
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/changelog Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
ci/woodpecker/pr/test-e2e Pipeline was successful
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin media-management:media-management
git switch media-management

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch develop
git merge --no-ff media-management
git switch media-management
git rebase develop
git switch develop
git merge --ff-only media-management
git switch media-management
git rebase develop
git switch develop
git merge --no-ff media-management
git switch develop
git merge --squash media-management
git switch develop
git merge --ff-only media-management
git switch develop
git merge media-management
git push origin develop
Sign in to join this conversation.
Reviewers
No reviewers
hj
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1
Instance Admin Dashboard

  
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility
https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!3603
No description provided.