Skip to content

HTTP: radically simplify pool checkin/checkout

rinpatch requested to merge feat/simplify-pool-managment into develop

Use a custom tesla middleware instead of adapter helper function + custom redirect middleware.

This will also fix "Client died before releasing the connection" messages when the request pool is overloaded. Since the checkout is now done after passing ConcurrentLimiter.

This is technically less efficient, since the connection needs to be checked in/out every time the middleware is left or entered respectively. But I don't think the nanoseconds we might lose on redirects to the same host are worth the complexity.

Merge request reports