Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pleroma pleroma
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 646
    • Issues 646
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 86
    • Merge requests 86
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PleromaPleroma
  • pleromapleroma
  • Merge requests
  • !3432

Deprecate Pleroma.Web.base_url/0

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alex Gleason requested to merge cycles-base-url into develop May 31, 2021
  • Overview 1
  • Commits 3
  • Pipelines 1
  • Changes 43

Helps recompilation: #2651 (closed)

Pleroma.Web.base_url() is a convenience function that calls Pleroma.Web.Endpoint.url() internally.

I don't believe this function is necessary. It only saves 4 characters. It's cleaner to just call Endpoint.url() directly.

This cuts down the size of most cycles: https://www.diffchecker.com/uRIjDZmg It introduces one small cycle in Pleroma.Config.Loader, but that will be dealt with in another MR. It's still an improvement for multiple reasons.

Edited May 31, 2021 by Alex Gleason
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cycles-base-url