Skip to content

Deprecate Pleroma.Web.base_url/0

Alex Gleason requested to merge cycles-base-url into develop

Helps recompilation: #2651 (closed)

Pleroma.Web.base_url() is a convenience function that calls Pleroma.Web.Endpoint.url() internally.

I don't believe this function is necessary. It only saves 4 characters. It's cleaner to just call Endpoint.url() directly.

This cuts down the size of most cycles: https://www.diffchecker.com/uRIjDZmg It introduces one small cycle in Pleroma.Config.Loader, but that will be dealt with in another MR. It's still an improvement for multiple reasons.

Edited by Alex Gleason

Merge request reports