Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pleroma pleroma
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 647
    • Issues 647
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 93
    • Merge requests 93
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PleromaPleroma
  • pleromapleroma
  • Merge requests
  • !3453

Recompilation speedup: use generic types in @spec in Upload.Filter

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alex Gleason requested to merge cycles-uploads into develop Jun 07, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

#2651 (closed)

A similar compromise to !3434 (merged) and !3435 (merged) - taking structs out of typespecs in favor of the generic struct().

The hard way to solve this problem would be to make Pleroma.Upload ONLY be the struct, and split all functions into a separate Pleroma.Uploads (plural) module. But short of that, this is an easier way to reach 0 cycles.

Gets rid of a cycle and shrinks others: https://www.diffchecker.com/6q6CpYJK

Screenshot_from_2021-06-07_17-15-30

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cycles-uploads