Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pleroma pleroma
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 646
    • Issues 646
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 89
    • Merge requests 89
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PleromaPleroma
  • pleromapleroma
  • Merge requests
  • !3454

Recompilation speedup: create WrapperAuthenticator and simplify Authenticator behaviour

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alex Gleason requested to merge cycles-authenticator into develop Jun 07, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 9

#2651 (closed)

Web.Auth.Authenticator has a similar problem as !3440 (merged), !3450 (merged) - it's both a behaviour and a config Wrapper module, creating compile-time cycles.

I broke it up into 3 separate modules:

  • Web.Auth.Authenticator - now strictly a behaviour, only contains @callback's
  • Web.Auth.WrapperAuthenticator - an Authenticator implementation that dynamically selects the auth module based on config
  • Web.Auth.Helpers - contains helper functions originally from Web.Auth.Authenticator

Now there's one less cycle (a big one) and the code is more idiomatic: https://www.diffchecker.com/534XPg3w

Screenshot_from_2021-06-07_18-15-41

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cycles-authenticator