Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pleroma pleroma
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 647
    • Issues 647
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 90
    • Merge requests 90
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PleromaPleroma
  • pleromapleroma
  • Merge requests
  • !3458

Recompilation speedup: Ignore runtime deps in Pleroma.Config.Loader with Module.concat/1

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alex Gleason requested to merge cycles-config-loader-redux into develop Jun 08, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

#2651 (closed)

In !3424 (merged) I changed @reject_keys on Config.Loader to runtime deps, but that wasn't enough. I've been putting off this MR because I wanted to see if my other changes would fix it, but it doesn't seem like it.

Having Config depend on Endpoint, even as a runtime dep, is not ideal because is creates cycles. And a lot of stuff has a compile-dep on Config.

Since @reject_keys is just checking the keys for equality (with ==, literally), it's okay to let the compiler ignore them with Module.concat/1. This is the way the Elixir team recommends you do it, if necessary.

This change cuts down a cycle and shrinks the rest: https://www.diffchecker.com/n9Jf8Sln

Screenshot_from_2021-06-08_16-14-15

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cycles-config-loader-redux