Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pleroma pleroma
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 653
    • Issues 653
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 98
    • Merge requests 98
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PleromaPleroma
  • pleromapleroma
  • Merge requests
  • !3459

Recompilation speedup: Switch to runtime deps in Pleroma.Instances

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Alex Gleason requested to merge cycles-instances into develop Jun 08, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

#2651 (closed)

Instance depends on Instances, but Instances has a compile-dep back on Instance.

To fix that, we can change the defdelegate calls into regular functions, converting Instance into a runtime dep.

Removes a cycle: https://www.diffchecker.com/Y3G4kZRP

Screenshot_from_2021-06-08_18-05-19

Edited Jun 08, 2021 by Alex Gleason
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cycles-instances