Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pleroma pleroma
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 580
    • Issues 580
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 97
    • Merge requests 97
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Pleroma
  • pleromapleroma
  • Merge requests
  • !3460

Recompilation speedup: Switch to runtime deps in ActivityPub.SideEffects

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alex Gleason requested to merge cycles-side-effects into develop Jun 08, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

#2651 (closed)

Essentially the same thing as !3427 (merged) - switching module attributes to private functions to prevent a compile dep.

Removes a cycle and shrinks others: https://www.diffchecker.com/J8Md7SaV

Screenshot_from_2021-06-08_18-16-56

Note that while this appears to remove the same cycle as !3459 (merged), it will actually remove an additional cycle when both are merged.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: cycles-side-effects