Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pleroma pleroma
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 647
    • Issues 647
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 88
    • Merge requests 88
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PleromaPleroma
  • pleromapleroma
  • Merge requests
  • !441

migrate CSP management to CSPPlug

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged kaniini requested to merge feature/csp-plug into develop Nov 11, 2018
  • Overview 4
  • Commits 12
  • Pipelines 12
  • Changes 10

Managing the various security parameters at the reverse proxy level has proven to be fragile for a multitude of reasons:

  • Administrators do not understand the scope of the options, so fail to see the importance of enabling them.
  • Administrators largely do not add new security options as we add them to the example configs.
  • Some reverse proxies have strange behavior when adding additional headers to the response, such as the nginx header case-sensitivity bug that broke CORS.

Accordingly, we move the security parameters to a plug that is managed in the same way as CORSPlug. This allows for administrators to no longer need to worry about keeping the security parameters up to date as the parameters are now managed by Pleroma itself. This means that security developers can simply push out new security parameters by updating CSPPlug.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/csp-plug