Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pleroma pleroma
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 645
    • Issues 645
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 88
    • Merge requests 88
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PleromaPleroma
  • pleromapleroma
  • Merge requests
  • !860

Bugfix #236 Prefer user look-up by nickname

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged \\\\\\\\\\\ requested to merge 11backslashes/pleroma:bugfix/236-ambiguous-route-for-numerical-handles into develop Feb 23, 2019
  • Overview 6
  • Commits 1
  • Pipelines 7
  • Changes 1

My first MR, so roast me.

The mocked user test data seems wonky. Are the user ids fed to Repo.get(User, id_or_nickname) supposed to look like: 9g8uJwiUS45y9g9Tmq? The way that function looked before made it seem like they're supposed to be strings that only contain digits.

Edited Feb 24, 2019 by \\\\\\\\\\\
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bugfix/236-ambiguous-route-for-numerical-handles