pleroma-elixir-libraries/fast_html
0
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity

System lexbor #44

Closed
lanodan wants to merge 0 commits from gitlab-mr-iid-27 into master
pull from: gitlab-mr-iid-27
merge into: pleroma-elixir-libraries:master
Conversation 3 Commits - Files changed -
lanodan commented 2023-07-16 20:55:58 +00:00
Owner
Copy link

Closes: #13

Closes: #13
lanodan commented 2023-08-17 23:19:30 +00:00
Author
Owner
Copy link

btw looking at https://git.pleroma.social/pleroma/elixir-libraries/fast_html/-/pipelines/45770 that's 30~45s which could be shaven off on decently powered amd64 machines, so likely more on arm64.

btw looking at https://git.pleroma.social/pleroma/elixir-libraries/fast_html/-/pipelines/45770 that's 30~45s which could be shaven off on decently powered amd64 machines, so likely more on arm64.
tusooa commented 2023-08-29 23:52:56 +00:00
Owner
Copy link

Causing build to fail on Gentoo.

==> fast_html
# Sadly, build components separately seems to sporadically fail
cd c_src/lexbor; \
	CFLAGS='-g -O2 -pedantic -Wcomment -Wextra -Wno-old-style-declaration -Wall' \
	time cmake -DLEXBOR_BUILD_SEPARATELY=OFF -DLEXBOR_BUILD_SHARED=OFF
/bin/sh: line 2: time: command not found
make: *** [Makefile:38: c_src/lexbor/liblexbor_static.a] Error 127
** (Mix) Could not compile with "make" (exit status: 2).
Please check you have: a C compiler, GNU Make, CMake and Erlang development headers installed before reporting an issue.

It turns out in bash (and zsh) time is a keyword and in ash time is a builtin.

] /bin/sh
sh-5.1$ type time
time is a shell keyword
sh-5.1$ CFLAGS=1 time ls
sh: time: command not found
sh-5.1$ 

] ash
~/Code/fast_html $ type time
time is time
~/Code/fast_html $ CFLAGS=1 time ls
CHANGELOG.md      Makefile          _build            c_src             deps              mix.exs           mix.lock.license
LICENSES          README.md         bench_fixtures    config            lib               mix.lock          test

] CFLAGS=1 time ls
zsh: parse error near `time'
Causing build to fail on Gentoo. ``` ==> fast_html # Sadly, build components separately seems to sporadically fail cd c_src/lexbor; \ CFLAGS='-g -O2 -pedantic -Wcomment -Wextra -Wno-old-style-declaration -Wall' \ time cmake -DLEXBOR_BUILD_SEPARATELY=OFF -DLEXBOR_BUILD_SHARED=OFF /bin/sh: line 2: time: command not found make: *** [Makefile:38: c_src/lexbor/liblexbor_static.a] Error 127 ** (Mix) Could not compile with "make" (exit status: 2). Please check you have: a C compiler, GNU Make, CMake and Erlang development headers installed before reporting an issue. ``` It turns out in bash (and zsh) `time` is a keyword and in ash `time` is a builtin. ``` ] /bin/sh sh-5.1$ type time time is a shell keyword sh-5.1$ CFLAGS=1 time ls sh: time: command not found sh-5.1$ ] ash ~/Code/fast_html $ type time time is time ~/Code/fast_html $ CFLAGS=1 time ls CHANGELOG.md Makefile _build c_src deps mix.exs mix.lock.license LICENSES README.md bench_fixtures config lib mix.lock test ] CFLAGS=1 time ls zsh: parse error near `time' ```
tusooa commented 2023-08-29 23:53:53 +00:00
Owner
Copy link
		time env CFLAGS='$(CFLAGS)' \
		cmake -DLEXBOR_BUILD_SEPARATELY=OFF -DLEXBOR_BUILD_SHARED=OFF
```suggestion:-1+0 time env CFLAGS='$(CFLAGS)' \ cmake -DLEXBOR_BUILD_SEPARATELY=OFF -DLEXBOR_BUILD_SHARED=OFF ```

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma-elixir-libraries/fast_html!44
No description provided.