Signup Error: [object Object]

Whenever there's a sign-up error for any reason, the user gets a "[object Object]" message, instead of an actual error.

In Firefox 68, if I mess up the captcha, then I get {"error":"{\"captcha\":[\"Invalid CAPTCHA\"]}"}.

It looks like signUp in src/modules/user.js is getting into its catch block and errors is a string containing a JSON object, but it isn't trying to humanize it because it's not an object according to typeof.

error appears to be a string instead of an object here in api.service.js:

return response.json().then((error) => { throw new Error(error) })

And then there's this in pleroma's Pleroma.Web.TwitterAPI.TwitterAPI.register_user:

    # Captcha invalid
    if captcha_ok != :ok do
      {:error, error} = captcha_ok
      # I have no idea how this error handling works
      {:error, %{error: Jason.encode!(%{captcha: [error]})}}

I might be able to hack something together for this assuming that the error is always going to be a string in a similar format to the one above.

yeah, FE needs better error handling overall

mentioned in merge request !888 (merged)

closed via merge request !888 (merged)

mentioned in commit 17dc7357

mentioned in commit mfc/pleroma-fe@4fc27414

After the changes I now get no error message box whatsoever, and I get a JavaScript error in the console

reopened

mentioned in merge request !920 (closed)

added Bug label

This displays a proper error message now

closed