Handle JSONified errors while registering

Closes #617 (closed)

I'm pretty sure this is not a good solution, but I did check all the errors I could find while looking through TwitterAPI.register_user and I don't think I saw any cases where this would fail.

should probably parse errors at lower level tho

I can't think of any place to do it besides the backend, and I don't think I see a good way to do it there. But yeah, this is a hack.

I mean you're handling it in modules/users, while it could be handled in api.service

added 1 commit

• 38666d71 - Clean up registration error handling

Compare with previous version

I decided to separate out the logic of building the error message from both api.service and users and also make a couple of other small stylistic fixes.

I tested this with CAPTCHA errors, an invalid invite token, and an error from Ecto (using an already taken nickname).

looks ok to me

looks good too, gotta test it a bit

merged

mentioned in commit 17dc7357

mentioned in issue #634 (closed)