Allow pleroma-fe users to identify as bot accounts

Looks like marking accounts as bots is supported per Issue #102 (closed)

However there isn't a way to do this in your account settings in pleroma-fe. Masto-fe doesn't have a settings panel it just takes you to the pleroma-fe one afaik

Looking to basically do this from mastodon:

iirc there was an issue/mr to have ability to set account type in general - bot, organization, person, group etc.

We need to open a backend issue for this if there isn't one already. The only way to get "bot" in your user data is to change your actor type directly in the database. Last time I looked at the code we ignored "bot" field updates to the user data.

I tried looking for one but didn't find it. All I could find was #102 (closed) which is more concerning the display of not status, not setting it

assigned to @ssuprunenko

when doing this, consider the ability to identify as other types of account (organization, group, etc)

there was some MR that allowed to do so but i have no idea what happened to that, i think BE part never went through or something. Or just FE never properly testing that

@hj i'd like to do that in a separate MR. First let's get the "This is a bot account." checkbox working which is a different problem than controlling the actor_type.

Right now bot is automatically applied based on actor_type:

https://git.pleroma.social/pleroma/pleroma/blob/develop/lib/pleroma/web/mastodon_api/views/account_view.ex#L182

and then we don't even allow the bot field to be processed if it's sent to /api/v1/accounts/update_credentials:

https://git.pleroma.social/pleroma/pleroma/blob/develop/lib/pleroma/web/mastodon_api/controllers/account_controller.ex#L150-180

There may be ... security considerations with allowing users to control actor_type. I'd like to hear what @lambadalambda thinks because that feels like something we should only allow through AdminFE/ Admin API. It's currently permitted via /api/v1/accounts/update_credentials, but I don't know if it should be.

yeah, just bot could be fine for now. Just to keep in mind the future.

actor_type for /api/v1/accounts/update_credentials is a Pleroma API extension and will be preserved, but we are going to tighten it down to only permit the values Person and Service.

bot field for /api/v1/accounts/update_credentials is going to be added in conformance with the Mastodon API.

if actor_type is set to Service it will automatically reflect the bot field as true as well.

mentioned in issue pleroma#1467 (closed)

mentioned in merge request !1153 (merged)

closed via merge request !1153 (merged)

mentioned in commit bbb91d8a