Skip to content
Snippets Groups Projects

Show who to follow in the mobile view

3 unresolved threads

After !443 (merged), instance specific panel, features panel, and who to follow panel are missing in the mobile view. In this MR, full who-to-follow list is shown in /who-to-follow endpoint.

Screen_Shot_2019-01-06_at_01.25.37 Screen_Shot_2019-01-06_at_01.26.23

Edited by Hakaba Hitoyo

Merge request reports

Pipeline #6128 passed

Pipeline passed for 3264e00d on hakabahitoyo:feature/show-who-to-follow-in-mobile-view

Approval is optional

Merged by HJHJ 6 years ago (Jan 16, 2019 2:33am UTC)

Merge details

  • Changes merged into develop with ea1d21aa (commits were squashed).
  • Deleted the source branch.

Pipeline #6276 passed

Pipeline passed for ea1d21aa on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
16 16 import UserPanel from 'components/user_panel/user_panel.vue'
17 17 import LoginForm from 'components/login_form/login_form.vue'
18 18 import ChatPanel from 'components/chat_panel/chat_panel.vue'
19 import WhoToFollowPage from 'components/who_to_follow_page/who_to_follow_page.vue'
  • Hakaba Hitoyo added 1 commit

    added 1 commit

    Compare with previous version

  • Hakaba Hitoyo added 1 commit

    added 1 commit

    Compare with previous version

  • Hakaba Hitoyo added 3 commits

    added 3 commits

    Compare with previous version

  • 2 import UserCard from '../user_card/user_card.vue'
    3
    4 const WhoToFollow = {
    5 components: {
    6 UserCard
    7 },
    8 data () {
    9 return {
    10 users: []
    11 }
    12 },
    13 mounted () {
    14 this.getWhoToFollow(this)
    15 },
    16 methods: {
    17 showWhoToFollow (panel, reply) {
  • 10 users: []
    11 }
    12 },
    13 mounted () {
    14 this.getWhoToFollow(this)
    15 },
    16 methods: {
    17 showWhoToFollow (panel, reply) {
    18 reply.forEach((i, index) => {
    19 const user = {
    20 id: 0,
    21 name: i.display_name,
    22 screen_name: i.acct,
    23 profile_image_url: i.avatar || '/images/avi.png'
    24 }
    25 panel.users.push(user)
  • Hakaba Hitoyo marked as a Work In Progress

    marked as a Work In Progress

  • Hakaba Hitoyo added 1 commit

    added 1 commit

    Compare with previous version

  • Hakaba Hitoyo unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Author Contributor

    Is anything to change? This MR seems complete.

  • HJ merged

    merged

  • HJ mentioned in commit ea1d21aa

    mentioned in commit ea1d21aa

  • Please register or sign in to reply
    Loading