Skip to content
Snippets Groups Projects

Support avatar placeholder

Merged Tae Hoon requested to merge tae/pleroma-fe:275-avatar-placeholder into develop
1 unresolved thread

Closes #275 (closed)

I added UserAvatar component which shows user avatar with fallback logic. It has some props related to UI variations for better usage.

Screenshot:

Screenshot_at_Feb_02_16-32-58

Merge request reports

Pipeline #6968 passed

Pipeline passed for e7f43d6b on tae:275-avatar-placeholder

Approval is optional

Merged by Shpuld ShpludsonShpuld Shpludson 6 years ago (Feb 4, 2019 4:17am UTC)

Merge details

Pipeline #6990 passed

Pipeline passed for d6ee6e83 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking

  • Thank you, this is a good change code-wise, separating components further. I'm gonna try it out a bit later today to see if everything still works correctly

  • Author Contributor

    @lanodan Hmm, I can't find /images/avi.png in develop branch. Could you please confirm that in develop branch, there is a placeholder avatar is served at /images/avi.png?

  • Author Contributor

    @lanodan Oh, I see now. I will fix it.

  • Tae Hoon added 1 commit

    added 1 commit

    • e7f43d6b - Use an existing image served by backend instead

    Compare with previous version

  • Author Contributor

    Fixed.

  • mentioned in commit d6ee6e83

  • Please register or sign in to reply
    Loading