#436: integrate mastoAPI notifications
Closes #436 (closed)
Edited by Dave LiPuma
Merge request reports
Activity
added 1 commit
- 2f7d890a - #436 (closed): add dismiss button, disable is_seen part
added 1 commit
- e5e1d4c6 - #436 (closed): fix notification order, follow type link issue, duplicate key
Sure.
Read
button is hidden temporarily untilis_seen
is implemented on the BE.And I implemented
clear
anddismiss
endpoints, and it was asked by users here (#412) before.- Updating UI makes it harder to test and review, I'd love to see clear/dismiss implementation as a separate MR
- Due to destructive nature of clear/dismiss it's probably better to make showing those elements only if option is enabled. Either way - it's up discussion.
So, pleas split UI changes off, so that we can merge MastoAPI changes quickier.
@hj it makes sense. I will focus on the API integration and will create separate MR for UI updates.
added 1 commit
- 8a0aa69a - #436 (closed): remove clear & dismiss UI updates
added 1 commit
- 52326e65 - #436 (closed): remove clear & dismiss UI updates
@hj I reverted the UI parts.
After this MR, I am going to create a
notification
module apart from thestatuses
. I'm going to refer this one - !672 (closed)Please let me know your thoughts on this.
added 8 commits
-
52326e65...9fd44e4a - 6 commits from branch
pleroma:develop
- 97a3f9c0 - Merge branch 'develop' of https://git.pleroma.social/pleroma/pleroma-fe into...
- adf4c5ee - #436 (closed): upgrade notification module
-
52326e65...9fd44e4a - 6 commits from branch
Please register or sign in to reply