Skip to content
Snippets Groups Projects

Fix sent follow request detection

Merged rinpatch requested to merge fix/incorrect-follow-request-status into develop
All threads resolved!

This fixes requestFollow using the relationship instead of user object, resulting in sent always being false for locked users, and also removes assumptions about follow request being sent, instead relying on requested from user relationship.

Merge request reports

Pipeline #15721 passed

Pipeline passed for 114b5f6e on fix/incorrect-follow-request-status

Approval is optional

Merged by HJHJ 5 years ago (Aug 9, 2019 12:57pm UTC)

Merge details

  • Changes merged into develop with 7e2d48a2.
  • Deleted the source branch.

Pipeline #15722 passed

Pipeline passed for 7e2d48a2 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • HJ
  • HJ
  • rinpatch added 1 commit

    added 1 commit

    • 4afa3ca4 - Fix sent follow request detection

    Compare with previous version

  • rinpatch added 1 commit

    added 1 commit

    • 26ed087a - Fix sent follow request detection

    Compare with previous version

  • HJ
  • Maintainer

    would probably be great to actually make it show "Request sent" in UI based on that field, since right now it will reset from navigating away from the page

  • HJ
  • rinpatch added 1 commit

    added 1 commit

    • 766bcc2a - Fix sent follow request detection

    Compare with previous version

  • rinpatch added 1 commit

    added 1 commit

    • e83b321f - Apply suggestion to src/services/follow_manipulate/follow_manipulate.js

    Compare with previous version

  • HJ
  • rinpatch added 1 commit

    added 1 commit

    • 5f3ac662 - Apply suggestion to src/services/follow_manipulate/follow_manipulate.js

    Compare with previous version

  • rinpatch added 1 commit

    added 1 commit

    • 114b5f6e - Apply suggestion to src/services/follow_manipulate/follow_manipulate.js

    Compare with previous version

  • HJ resolved all discussions

    resolved all discussions

  • Maintainer

    LGTM, if you want, displaying the "request sent" could be done in a separate MR, just make an issue about it.

  • Author Contributor
  • HJ merged

    merged

  • HJ mentioned in commit 7e2d48a2

    mentioned in commit 7e2d48a2

  • Maintainer

    if anything breaks i'm gonna fix it myself - that code needs more comments anyway

  • Please register or sign in to reply
    Loading