interaction with BE private mode

This MR basically removes links and other UI elements for guest users that will not work when private mode is enabled.

added 1 commit

• afff97f7 - boot: track whether private mode is enabled or not

Compare with previous version

added 7 commits

• afff97f7...3dae1cf3 - 4 commits from branch develop
• 621ac0bd - docs: document FE interaction with the BE private setting
• 99fd096d - boot: track whether private mode is enabled or not
• 21f1637e - nav panel: refactor to use vuex mapState

Compare with previous version

added 1 commit

• ee2d3ea2 - nav panel: disable TWKN if federation disabled, disable Public and TWKN if privateMode is enabled

Compare with previous version

added 2 commits

• 1f967435 - nav panel: disable TWKN if federation disabled, disable Public and TWKN if privateMode is enabled
• cb5f7314 - app: search API is not available in private mode so disable it

Compare with previous version

unmarked as a Work In Progress

added 1 commit

• 43d4d17b - side drawer: same treatment

Compare with previous version

mentioned in merge request !992 (closed)

code changes look fine to me, didn't test

Not sure how exactly private mode works, but hacking it in FE to be true still allows opening public timeline and twkn via direct link/if instance has those pages set up as default redirect for logged-out visitors. Probably should redirect them to /about or something?

non-private mode seems to be working fine.

In the BE private: true is not the same as federating: false

You can have a server that is Federating but is Private. So why remove TWKN and other federating features for private?

because BE will deny unauthorized access to those timelines?

Alright, so we need a separate MR for federating: false then as well which does pretty much all of this but also affects when you're logged in.

No, we won't need that, this MR already handles federating just fine. The conditionals are short-circuiting in JavaScript.

Is this ready to be merged?

Checking in again

added 62 commits

• 43d4d17b...051b9703 - 61 commits from branch develop
• 821a2bcc - Merge branch 'develop' into feature/lockdown-timelines-private-mode

Compare with previous version

added 2 commits

• 3eeb3dc5 - Lint
• 211d25cd - More lint

Compare with previous version

added 1 commit

• afe5b3a8 - More lint

Compare with previous version

added 1 commit

• 7ddd5af0 - Finally trust eslint

Compare with previous version

added 2 commits

• 2514dc18 - Logic should be to hide TWKN if not federating OR if instance is not public
• 0743fbb2 - The value we are looking for is federationPolicy.enabled, not federationPolicy.federating

Compare with previous version

added 1 commit

• 8d14036a - Add fallback in case BE does not report federating status in nodeinfo

Compare with previous version

resolved all threads

added 1 commit

• d899d069 - Use a centralized fallback for missing values and use instance.federating instead of

Compare with previous version

merged

mentioned in commit 0b49e798

mentioned in issue #759 (closed)

mentioned in issue pleroma#1397 (closed)