Fix server-side default of collapse_message_with_subject = true #1618

Closed
scarlett wants to merge 1 commit from gitlab-mr-iid-346 into develop
Member

This setting was being ignored after the transition to server-side
configuration. Make sure it's honoured again.

This setting was being ignored after the transition to server-side configuration. Make sure it's honoured again.
Member

This breaks user configuration of same setting.

This breaks user configuration of same setting.
Author
Member

Explain how. I tested this with a server that had it default to off (can be turned on), and a server that had it default to on (can be turned off).

Explain how. I tested this with a server that had it default to off (can be turned on), and a server that had it default to on (can be turned off).
Member

This setting right here:

image

Gets overwritten on page refresh with server ones if you apply your changes. Some users have been complaining #143 about that the setting specifically doesn't get saved on page refresh even after a lot of time has passed. Commits 5726be68 and 6e64324d fix that by changing the name of server provided one and adding a condition to fall back to server-provided one if user setting doesn't exist, though until #1615 is merged there may be some issues related to user config always existing.

In #1615 it's a different approach and user settings are stored separately from server settings.

This setting right here: ![image](/attachments/7f44cdfd-3b31-437e-8e29-2f0d463d5ccb) Gets overwritten on page refresh with server ones if you apply your changes. Some users have been complaining #143 about that the setting specifically doesn't get saved on page refresh even after a lot of time has passed. Commits 5726be68 and 6e64324d fix that by changing the name of server provided one and adding a condition to fall back to server-provided one if user setting doesn't exist, though until #1615 is merged there may be some issues related to user config always existing. In #1615 it's a different approach and user settings are stored separately from server settings.
Member

Please note that this MR will reopen #143

Please note that this MR will reopen #143
Member

I've added something to display what instance default is in #1615

image

I've added something to display what instance default is in #1615 ![image](/attachments/2f0a3d25-bce3-4ab0-b8b8-607c5f3122b7)
Member

obsoleted by #1615

obsoleted by #1615

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!1618
No description provided.