#340 Fix UI of followers list #1833

Closed
edijs wants to merge 0 commits from gitlab-mr-iid-563 into develop
Member

Issue #343 #340

Here is the screenshots what it looks like

Screen_Shot_2019-02-12_at_9.01.51_AM

@shpuld I didn't update Stop following in this PR because idk how to translate other i18n words.

Issue #343 #340 Here is the screenshots what it looks like ![Screen_Shot_2019-02-12_at_9.01.51_AM](/attachments/20383077-2d9d-417b-aa06-63028c826adb) @shpuld I didn't update `Stop following` in this PR because idk how to translate other i18n words.
Owner

HUGE usability improvement, thanks!

HUGE usability improvement, thanks!
Member

This doesn't seem right, what does it do?

This doesn't seem right, what does it do?
Member

You can just remove the "compact" prop from the avatar instead of overriding styles

You can just remove the "compact" prop from the avatar instead of overriding styles
Member

By the way, something I tried briefly myself, .btn-default is not actually defined anywhere, but it could be used to give buttons the min-height: 28px that most of them already have (smaller buttons also look quite bad). That could be done in App.scss

By the way, something I tried briefly myself, .btn-default is not actually defined anywhere, but it could be used to give buttons the min-height: 28px that most of them already have (smaller buttons also look quite bad). That could be done in App.scss
Member

Doesn't need its own class, could just use "faint" (especially not a link color for something that's not a link)

Doesn't need its own class, could just use "faint" (especially not a link color for something that's not a link)
Member

Looks much nicer already! I'll have another look after we have a stable master!

Looks much nicer already! I'll have another look after we have a stable master!
Member

I was checking this out locally as it fixes some things I'd really want in the stable master, but I found out one problem with it, expanding a profile in the list is a bit broken

follows_broken

I was checking this out locally as it fixes some things I'd really want in the stable master, but I found out one problem with it, expanding a profile in the list is a bit broken ![follows_broken](/attachments/07cb29db-02f8-462f-a650-ff9dda5f15ae)
Member

Double comment to make this into an unresolved:

  • size/position of the expanded user card isn't correct
  • there's some pixel offset between the avatar top and expanded user card top
Double comment to make this into an unresolved: - size/position of the expanded user card isn't correct - there's some pixel offset between the avatar top and expanded user card top
Member

Checked on develop, the "stop following" shouldn't also be there when the card is expanded, as the card already has a button for unfollowing

Checked on develop, the "stop following" shouldn't also be there when the card is expanded, as the card already has a button for unfollowing
Owner

Instead of expanding the card there why not have it just open the profile? The expansion of user profile cards is a really strange UX decision that doesn't feel natural IMO. This one isn't even a timeline that you'd be leaving from.

Instead of expanding the card there why not have it just open the profile? The expansion of user profile cards is a really strange UX decision that doesn't feel natural IMO. This one isn't even a timeline that you'd be leaving from.
Member

it might seem strange but once you're used to it, you don't really want to give it up either. it's very handy to be able to see the important stuff about other profiles without doing additional navigation.

it might seem strange but once you're used to it, you don't really want to give it up either. it's very handy to be able to see the important stuff about other profiles without doing additional navigation.
Member

Took over and made a new MR off this code with some improvements at #1860

I'm closing this one to not have two MR's with the same changes

Took over and made a new MR off this code with some improvements at #1860 I'm closing this one to not have two MR's with the same changes

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma-fe!1833
No description provided.