pleroma/pleroma-fe
0
0
Fork 0
Code Issues 343 Pull requests 27 Projects Releases Packages Wiki Activity

Feature - Collapse conversation by clicking outside #1885

Closed
edijs wants to merge 7 commits from gitlab-mr-iid-615 into develop
pull from: gitlab-mr-iid-615
merge into: pleroma:develop
Conversation 5 Commits 7 Files changed 8 +70 -5
edijs commented 2019-02-26 02:08:29 +00:00
Member
Copy link

Closes #393

Closes #393
shpuld commented 2019-02-28 18:04:32 +00:00
Owner
Copy link

As an option this is fine, but I think you should make it so that it scrolls you where the expanded post was when you close it the conversation.

As an option this is fine, but I think you should make it so that it scrolls you where the expanded post was when you close it the conversation.
shpuld commented 2019-03-01 17:05:50 +00:00
Owner
Copy link

This is a bit cryptic like this, I know it's for keeping count of the expanded statuses on a timeline but it also doesn't make sense in this context alone which means the logic is spread in too many places.

I also am a bit unsure if the timeline should have control over this, maybe something like this would work, when you click outside, all the expanded do this sort of an operation: if view is below the top of the conversation, scroll by the amount to reach the top, these together should work without having to actually communicate together. I'm not 100% sure if it would work perfectly like this tho

This is a bit cryptic like this, I know it's for keeping count of the expanded statuses on a timeline but it also doesn't make sense in this context alone which means the logic is spread in too many places. I also am a bit unsure if the timeline should have control over this, maybe something like this would work, when you click outside, all the expanded do this sort of an operation: if view is below the top of the conversation, scroll by the amount to reach the top, these together should work without having to actually communicate together. I'm not 100% sure if it would work perfectly like this tho
edijs commented 2019-03-01 17:31:00 +00:00
Author
Member
Copy link

Yes, this is to count the number of expanded statuses on a timeline.

But the counting is only used to display Collapse All button on mobile view.

As we discussed, on mobile view background clicking does not work, instead Collapse All button will be displayed at top right if there are any expanded statuses.

All other operations are working as you said.

Yes, this is to count the number of expanded statuses on a timeline. But the counting is only used to display `Collapse All` button on mobile view. As we discussed, on mobile view background clicking does not work, instead `Collapse All` button will be displayed at top right if there are any expanded statuses. All other operations are working as you said.
shpuld commented 2019-03-01 18:02:40 +00:00
Owner
Copy link

Ah I see, thanks for the explanation, couldn't tell it immediately from code alone. Perhaps some naming of things could be changed to indicate better what it's for so less confusion like this happens when others read the code?

Ah I see, thanks for the explanation, couldn't tell it immediately from code alone. Perhaps some naming of things could be changed to indicate better what it's for so less confusion like this happens when others read the code?
edijs commented 2019-03-01 18:26:11 +00:00
Author
Member
Copy link

Gotcha, let me update it

Gotcha, let me update it

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!1885
No description provided.