pleroma/pleroma-fe
0
0
Fork 0
Code Issues 343 Pull requests 27 Projects Releases Packages Wiki Activity

WIP: Add ability to pin posts #2009

Closed
Dave wants to merge 17 commits from gitlab-mr-iid-739 into develop
pull from: gitlab-mr-iid-739
merge into: pleroma:develop
Conversation 14 Commits 17 Files changed 33 +328 -95
Dave commented 2019-04-09 15:43:55 +00:00
Member
Copy link

Closes #468

Screenshots

unpin_status

pin_status

Closes #468 Screenshots ![unpin_status](/attachments/1abd5fa2-a942-4aa9-b531-870476bec4b5) ![pin_status](/attachments/7d647350-6c77-4b48-81a4-f5d41cf38b22)
unpin_status.png
97 KiB
pin_status.png
38 KiB
shpuld commented 2019-04-09 16:42:08 +00:00
Owner
Copy link

would it be appropriate to use the $status-margin defined in this file for the 0.75?

would it be appropriate to use the $status-margin defined in this file for the 0.75?
shpuld commented 2019-04-09 16:58:53 +00:00
Owner
Copy link

The [+] icon become fatter somehow

The [+] icon become fatter somehow
shpuld commented 2019-04-09 17:05:14 +00:00
Owner
Copy link

I'm thinking, maybe it would be an appropriate place to add an ellipsis button in the status-actions, and put pin, delete and maybe "open original" in the ellipsis menu, the top corner is getting a bit too cluttered as it stands.. @hj thoughts?

I'm thinking, maybe it would be an appropriate place to add an ellipsis button in the status-actions, and put pin, delete and maybe "open original" in the ellipsis menu, the top corner is getting a bit too cluttered as it stands.. @hj thoughts?
shpuld commented 2019-04-09 17:18:04 +00:00
Owner
Copy link

I don't think direct messages should have the pin icon, maybe only public/unlisted ones should have them?

I don't think direct messages should have the pin icon, maybe only public/unlisted ones should have them?
hj commented 2019-04-09 17:18:34 +00:00
Owner
Copy link

ellipsis was an idea for a long time. Putting it where "open original is" is a neat idea, but I'm not sure. I do like idea of adding "open original" into ellipsis menu tho

ellipsis was an idea for a long time. Putting it where "open original is" is a neat idea, but I'm not sure. I do like idea of adding "open original" into ellipsis menu tho
hj commented 2019-04-09 17:19:06 +00:00
Owner
Copy link

i'm ok with DMs having pins tbh, one could just leave a note to themselves this way

i'm ok with DMs having pins tbh, one could just leave a note to themselves this way
rinpatch commented 2019-04-09 17:22:09 +00:00
Member
Copy link

The backend limits pins to public/unlisted

The backend limits pins to public/unlisted
hj commented 2019-04-09 17:22:22 +00:00
Owner
Copy link

oh, ok, thanks @rinpatch

oh, ok, thanks @rinpatch
Dave commented 2019-04-09 17:23:26 +00:00
Author
Member
Copy link

That was why I got Could not pin error code. thank you for the confirmation @rinpatch

That was why I got `Could not pin` error code. thank you for the confirmation @rinpatch
shpuld commented 2019-04-09 17:24:15 +00:00
Owner
Copy link

I'm not sure if treating pinned statuses as a timeline is worth it, especially here it shows that we add some completely different behavior to this function just for pinned statuses. I know they're fetched like a timeline in the API but the way they're dealt with in the application is fairly different, we don't really need to poll for them, updating pinned statuses is fine if done only when opening a user profile or when pinning/unpinning something yourself.

I'm not sure if treating pinned statuses as a timeline is worth it, especially here it shows that we add some completely different behavior to this function just for pinned statuses. I know they're fetched like a timeline in the API but the way they're dealt with in the application is fairly different, we don't really need to poll for them, updating pinned statuses is fine if done only when opening a user profile or when pinning/unpinning something yourself.
shpuld commented 2019-04-09 18:12:24 +00:00
Owner
Copy link

@hj oh I meant putting it in status-actions, meaning where "delete" is now

@hj oh I meant putting it in status-actions, meaning where "delete" is now
Dave commented 2019-04-09 18:13:34 +00:00
Author
Member
Copy link

@shpuld do you mean at the bottom?

@shpuld do you mean at the bottom?
shpuld commented 2019-04-09 18:28:34 +00:00
Owner
Copy link

yes, right from favorite star, replacing delete on your own statuses (and putting delete into that menu instead)

yes, right from favorite star, replacing delete on your own statuses (and putting delete into that menu instead)
tae commented 2019-04-25 01:42:57 +00:00
Member
Copy link

moved to #2039 since it is not allowed to edit this MR.

moved to https://git.pleroma.social/pleroma/pleroma-fe/pulls/2039 since it is not allowed to edit this MR.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!2009
No description provided.