pleroma/pleroma-fe
0
0
Fork 0
Code Issues 343 Pull requests 27 Projects Releases Packages Wiki Activity

Add ability to pin posts #2039

Closed
tae wants to merge 0 commits from gitlab-mr-iid-770 into develop
pull from: gitlab-mr-iid-770
merge into: pleroma:develop
Conversation 34 Commits - Files changed -
tae commented 2019-04-25 01:42:17 +00:00
Member
Copy link

Closes #468

(based on #2009)

NOTE: I've removed "pinned" timeline and its polling logic. Instead, I came up with a more elegant way to filter pinned statuses from the "user" timeline.

Screenshots

Screenshot_at_Apr_24_21-39-52

Screenshot_at_Apr_24_21-39-26

Closes #468 (based on https://git.pleroma.social/pleroma/pleroma-fe/pulls/2009) **NOTE:** I've removed "pinned" timeline and its polling logic. Instead, I came up with a more elegant way to filter pinned statuses from the "user" timeline. **Screenshots** ![Screenshot_at_Apr_24_21-39-52](/attachments/fa20147d-c0aa-445d-a30f-d46b852ac2c9) ![Screenshot_at_Apr_24_21-39-26](/attachments/bcaa680b-8e31-4849-8e02-97289cc7f071)
Screenshot_at_Apr_24_21-39-52.png
654 KiB
Screenshot_at_Apr_24_21-39-26.png
579 KiB
kaniini commented 2019-04-25 02:46:07 +00:00
Member
Copy link

on pleroma.site, pinning posts on this branch makes a request to /undefined.

on pleroma.site, pinning posts on this branch makes a request to `/undefined`.
tae commented 2019-04-25 02:47:37 +00:00
Author
Member
Copy link

could you provide me steps to reproduce?

could you provide me steps to reproduce?
kaniini commented 2019-04-25 03:12:31 +00:00
Member
Copy link

write a post, go to my profile, click "pin this post"

write a post, go to my profile, click "pin this post"
tae commented 2019-04-25 03:24:52 +00:00
Author
Member
Copy link

it works great on my end. could you provide me a full URL of the request?

it works great on my end. could you provide me a full URL of the request?
hj commented 2019-04-25 12:47:34 +00:00
Owner
Copy link

can it be just text color instead?

can it be just text color instead?
hj commented 2019-04-25 12:50:08 +00:00
Owner
Copy link

i'd rather not. make error manually dismissable and clear it automatically when successful action occurs

i'd rather not. make error manually dismissable and clear it automatically when successful action occurs
hj commented 2019-04-25 12:52:41 +00:00
Owner
Copy link

should be an <a>

should be an `<a>`
hj commented 2019-04-25 12:53:16 +00:00
Owner
Copy link

same here

same here
hj commented 2019-04-25 12:54:00 +00:00
Owner
Copy link

this won't be needed if you use <a>

this won't be needed if you use `<a>`
hj commented 2019-04-25 12:55:24 +00:00
Owner
Copy link

woudln't it be better to just use result of fetching fetchPinnedStatuses?

woudln't it be better to just use result of fetching `fetchPinnedStatuses`?
hj commented 2019-04-25 12:56:31 +00:00
Owner
Copy link

can't you read pinned property from the status itself?

can't you read pinned property from the status itself?
hj commented 2019-04-25 13:01:48 +00:00
Owner
Copy link

i feel that "Pinned" label should actually be left aligned.

i feel that "Pinned" label should actually be left aligned.
kaniini commented 2019-04-25 21:21:52 +00:00
Member
Copy link

https://pleroma.site/undefined

`https://pleroma.site/undefined`
kaniini commented 2019-04-26 02:54:33 +00:00
Member
Copy link

this should be translatable

this should be translatable
kaniini commented 2019-04-26 02:55:49 +00:00
Member
Copy link

Typo

Typo
kaniini commented 2019-04-26 03:00:44 +00:00
Member
Copy link

???? why is this in the MR

???? why is this in the MR
tae commented 2019-04-26 17:25:17 +00:00
Author
Member
Copy link

Thanks for all the reviews. This MR is based on the other's previous MR and I resolved here only a few items issued in the last review. I will go through everything soon. :)

Thanks for all the reviews. This MR is based on the other's previous MR and I resolved here only a few items issued in the last review. I will go through everything soon. :)
tae commented 2019-04-26 20:03:11 +00:00
Author
Member
Copy link

yeah, normally, this is wrong. However, I suggest to include this.
The problem is that the font project is not merged automatically. In my experience, whenever we merged origin/develop into mfc/develop, we needed to generate the font again through a third-party platform which is very annoying.
It really makes life easier if we manage the font in one repo.

yeah, normally, this is wrong. However, I suggest to include this. The problem is that the font project is not merged automatically. In my experience, whenever we merged `origin/develop` into `mfc/develop`, we needed to generate the font again through a third-party platform which is very annoying. It really makes life easier if we manage the font in one repo.
tae commented 2019-04-26 20:09:16 +00:00
Author
Member
Copy link

good catch! 👍

good catch! :thumbsup:
tae commented 2019-04-26 20:12:20 +00:00
Author
Member
Copy link

it's not, because there can be more pinned statuses by polling user timeline or pinned state can be changed by user action.

it's not, because there can be more pinned statuses by polling user timeline or `pinned` state can be changed by user action.
tae commented 2019-04-26 20:31:40 +00:00
Author
Member
Copy link

I agree. 👍

I agree. :thumbsup:
tae commented 2019-04-26 20:44:12 +00:00
Author
Member
Copy link

could you test again? 😄

could you test again? :smile:
kaniini commented 2019-04-26 23:43:08 +00:00
Member
Copy link

still doing an HTTP GET to https://pleroma.site/undefined when I click the pin post option.

still doing an HTTP GET to https://pleroma.site/undefined when I click the pin post option.
tae commented 2019-04-27 02:54:33 +00:00
Author
Member
Copy link

I've registered my account to your instance. However, I can't see the "pin" button. Could you deploy, so I can test the "pin" feature on your instance?

I've registered my account to your instance. However, I can't see the "pin" button. Could you deploy, so I can test the "pin" feature on your instance?
kaniini commented 2019-04-27 04:25:13 +00:00
Member
Copy link

it is deployed. you can only pin your own statuses.

it is deployed. you can only pin your own statuses.
tae commented 2019-04-27 13:02:05 +00:00
Author
Member
Copy link

could you update your instance with the latest changes?

could you update your instance with the latest changes?
hj commented 2019-04-28 15:41:15 +00:00
Owner
Copy link

Then filter over first/last 20 elements? This could get laggy when loading timeline deeper and deeper

Then filter over first/last 20 elements? This could get laggy when loading timeline deeper and deeper
hj commented 2019-04-28 15:44:00 +00:00
Owner
Copy link

i vote against this. There's no need to keep in sync with all the forks, might as well just pull all the icons there are to avoid any possible conflicts.

i vote against this. There's no need to keep in sync with all the forks, might as well just pull all the icons there are to avoid any possible conflicts.
tae commented 2019-04-29 18:49:49 +00:00
Author
Member
Copy link

removed

removed
tae commented 2019-04-30 20:20:54 +00:00
Author
Member
Copy link

refactored using an entity of user object

refactored using an entity of user object
shpuld commented 2019-05-07 17:10:36 +00:00
Owner
Copy link

Might be better on the left, but not sure. I don't think it matters too much especially for the first version

Might be better on the left, but not sure. I don't think it matters too much especially for the first version
shpuld commented 2019-05-07 17:11:14 +00:00
Owner
Copy link

It works and looks fine for me

It works and looks fine for me
shpuld commented 2019-05-07 17:11:40 +00:00
Owner
Copy link

still relevant @kaniini ?

still relevant @kaniini ?
kaniini commented 2019-05-15 18:21:01 +00:00
Member
Copy link

current version is working well.

current version is working well.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!2039
No description provided.