pleroma/pleroma-fe
0
0
Fork 0
Code Issues 343 Pull requests 27 Projects Releases Packages Wiki Activity

Indicate whether collapsed statuses contain gallery media or link preview cards #2323

Closed
xenofem wants to merge 0 commits from gitlab-mr-iid-1056 into develop
pull from: gitlab-mr-iid-1056
merge into: pleroma:develop
Conversation 8 Commits - Files changed -
xenofem commented 2020-02-08 18:18:47 +00:00
Member
Copy link

Fixes #767

Currently this shows a picture icon for any kind of gallery media, if you'd like I can adjust it to distinguish between images and videos.

Fixes #767 Currently this shows a picture icon for any kind of gallery media, if you'd like I can adjust it to distinguish between images and videos.
shpuld commented 2020-02-08 20:13:33 +00:00
Owner
Copy link

This won't cover all attachments, for example if you have a video that's played on the timeline is not in gallery

This won't cover all attachments, for example if you have a video that's played on the timeline is not in gallery
xenofem commented 2020-02-08 20:49:02 +00:00
Author
Member
Copy link

Thanks for catching that, I'll push a fix!

Thanks for catching that, I'll push a fix!
hj commented 2020-02-08 20:57:49 +00:00
Owner
Copy link

i'm not sure if it's needed or the icon should be different because you could post a link that won't generate a card at all

i'm not sure if it's needed or the icon should be different because you could post a link that won't generate a card at all
xenofem commented 2020-02-08 21:06:21 +00:00
Author
Member
Copy link

Hmmm, looking at link-preview.js, the BE isn't supposed to provide preview cards at all for NSFW statuses, but we still make sure to hide any preview card images that show up in NSFW statuses somehow. If we're paranoid enough to add code to handle that case, I feel like we should be consistently paranoid and indicate the presence of a link, and it's not like it hurts anything to do so. If you have suggestions for a better icon I'm all ears.

Hmmm, looking at `link-preview.js`, the BE isn't supposed to provide preview cards at all for NSFW statuses, but we still make sure to hide any preview card images that show up in NSFW statuses somehow. If we're paranoid enough to add code to handle that case, I feel like we should be consistently paranoid and indicate the presence of a link, and it's not like it hurts anything to do so. If you have suggestions for a better icon I'm all ears.
shpuld commented 2020-02-10 08:15:28 +00:00
Owner
Copy link

BE doesn't provide cards at all or just without images?

BE doesn't provide cards at all or just without images?
shpuld commented 2020-02-10 08:16:26 +00:00
Owner
Copy link

I don't think we need to treat previewless links differently in general, it makes no difference if there's one or not. the preview is what we want to indicate since it can have images.

I don't think we need to treat previewless links differently in general, it makes no difference if there's one or not. the preview is what we want to indicate since it can have images.
xenofem commented 2020-02-10 08:31:33 +00:00
Author
Member
Copy link

Yeah, I'm testing status.card which unless I'm very confused should only be truthy if there's a preview card?

Yeah, I'm testing `status.card` which unless I'm very confused should only be truthy if there's a preview card?
shpuld commented 2020-02-10 08:48:39 +00:00
Owner
Copy link

yes you're correct, I'm just saying that we shouldn't worry about previewless links at all anywhere, so this is fine.

yes you're correct, I'm just saying that we shouldn't worry about previewless links at all anywhere, so this is fine.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
BE Request

   
Backlog

   
Better behavior

   
Blocked by deps

   
Bug

   
Code Review

   
Discussion

   
Doing

   
Feature Request / Enhancement

   
In the shining bright future maybe

   
It's complicated

   
MS Edge

   
Mememoon (or other niche browsers)

   
Missing API

   
Missing feature

   
Missing l10n/i18n

   
NL1

Instance Admin Dashboard

  
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
Need to verify on develop

   
RELEASE BLOCKER

   
Reassign or Close

   
Refactor

   
Regression

   
Safari

   
To Do

   
User story

   
Waiting on godot

   
accessibility

https://git.pleroma.social/pleroma/pleroma-fe/-/snippets/7746

  
better documentation

   
chore

   
confirmed

   
easy ticket

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
l10n update

   
mastoapi

   
mobile

   
needs design

   
needs-info

   
needs-review

   
stupid
No labels
BE Request
Backlog
Better behavior
Blocked by deps
Bug
Code Review
Discussion
Doing
Feature Request / Enhancement
In the shining bright future maybe
It's complicated
MS Edge
Mememoon (or other niche browsers)
Missing API
Missing feature
Missing l10n/i18n
NL1
NL2
NL4
Need to verify on develop
RELEASE BLOCKER
Reassign or Close
Refactor
Regression
Safari
To Do
User story
Waiting on godot
accessibility
better documentation
chore
confirmed
easy ticket
incident
l10n update
mastoapi
mobile
needs design
needs-info
needs-review
stupid
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!2323
No description provided.