WIP: Move all Notifications settings to the Notifications tab #2466

Closed
feld wants to merge 1 commit from gitlab-mr-iid-1199 into develop
Owner

fixes #401

fixes #401
Author
Owner

@shpuld it's very annoying how some settings are instantly activated and others require a submit button. We are very inconsistent across all of our settings. I'm unclear exactly how this works in this tab but it would be nice if we were consistent about this everywhere.

@shpuld it's very annoying how some settings are instantly activated and others require a submit button. We are very inconsistent across all of our settings. I'm unclear exactly how this works in this tab but it would be nice if we were consistent about this everywhere.
Author
Owner

Filtering tab:

image

Notifications tab:

image

Filtering tab: ![image](/attachments/008bb126-cf06-444a-af10-33f37b2d9174) Notifications tab: ![image](/attachments/573cfe0a-3d2a-491a-80b6-c211395a1dd4)
182 KiB
240 KiB
Author
Owner

I feel like Filtering tab should have a header for consistency, and Notifications tab header should maybe be "Notification Filters".

Other than fixing how settings are saved/submitted, this is much better for users as all of the Notifications settings are now in one place.

I feel like Filtering tab should have a header for consistency, and Notifications tab header should maybe be "Notification Filters". Other than fixing how settings are saved/submitted, this is much better for users as all of the Notifications settings are now in one place.
Owner

that's why they were different pages before.

i don't have a solution for it yet but i'm thinking about it.

that's why they were different pages before. i don't have a solution for it yet but i'm thinking about it.

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma-fe!2466
No description provided.