Deprecation warning/convertion for instance reasons not always properly working
With quarantine and mrf_simple, people can moderate instances. In !3314 (merged) we added the ability to add reasons per instance why it is moderated the way it is.
To do that, the settings have been changed. Instead of just a list of strings, we have a list of tuples.
During startup Pleroma loads the settings and checks if there are deprecated settings. If so, a warning is provided and the settings will be converted to the "new" format in-memory. (See line 65 in lib/pleroma/config/deprecation_warnings.ex of the MR).
Even though this seems to work in most cases (or at least when I try myself), we've had two occasions where this didn't seem to work properly.
Before this MR, there was a bug that made the checks not always correctly happen. If one check failed, the rest wouldn't be done any more. But that bug was fixed also in that MR. (See line 170 in lib/pleroma/config/deprecation_warnings.ex of the MR)
I tried locally with the configurations from pleroma-support#69 (closed) but locally it worked as expected. So I have no idea why it sometimes fails now and I have no idea how to reproduce :/