Fix public option not working

by responding with 403 to GET /api/v1/timelines/public when public is set to false

Fixes #873 (closed)

marked as a Work In Progress

changed the description

1. From docs/config.md

public: Makes the client API in authentificated mode-only except for user-profiles. Useful for disabling the Local Timeline and The Whole Known Network.

so TWKN (federated timeline) should also disabled
Nevermind, forgot they are one endpoint in mastoapi

2. I really don't think you should do this in the controller, instead implement a plug called Pleroma.Plugs.EnsurePublicOrAuthenticatedPlug which would let the conn continue if the instance is public or the user is authenticated and throw a 403 otherwise. Then pipe requests to timelines through this plug

Okay. Thanks for the feedback!

added 34 commits

• 782d7398...cdcdbd88 - 32 commits from branch pleroma:develop
• a18b2c0b - Fix Pleroma.Config.get!/1 raising an error when value is false
• b8210d86 - Fix public option not working

Compare with previous version

added 2 commits

• 069ee752 - Implement Pleroma.Plugs.EnsurePublicOrAuthenticated
• d847f754 - Pipe requests to public endpoints through EnsurePublicOrAuthenticatedPlug

Compare with previous version

unmarked as a Work In Progress

added 32 commits

• d847f754...c133c32e - 30 commits from branch pleroma:develop
• 7b8dc99e - Implement Pleroma.Plugs.EnsurePublicOrAuthenticated
• 70c81b95 - Pipe requests to public endpoints through EnsurePublicOrAuthenticatedPlug

Compare with previous version

mentioned in commit 62516be9

merged

mentioned in issue #1045 (closed)