Moving mrf settings from instance to separate mrf group

Closes #1631 (closed)

I think there should be either:

• Blocker (similar to when migrations aren't done?) when the old config is used
• Warning + compatibility for the old config, to deprecate it

1. There should be a migration for in-db config
2. as @lanodan said, we should support the old config still. Just do something like that in Pleroma.Config.DeprecationWarnings

@config_map [{[:instance, :rewrite_policy], [:mrf, :policies]}, {[:instance, :mrf_transparency], [:mrf, :transparency]}, {[:instance, :mrf_transparency_exclusions], [:mrf, :transparency_exclusions]}]

old_namespaces_detected = Enum.reduce(@config_map, [], fn {old, new} = namespace_change, acc ->
  old_config = Pleroma.Config.get(old)
  if old_config do
    Pleroma.Config.put(new, old_config)
    [namespace_change | acc]
  else
    acc
  end
end)

if old_namespaces_detected != [] do
  # the move points should be generated based on old_namespaces_detected, not implemented because it's hard and this is just an example
  Logger.warn("""
              Your config is using old namespaces for MRF configuration. They should work for now, but you are advised to change to new namespaces to prevent possible issues later:
              * `config :pleroma, :instance, rewrite_policy` is now `config :pleroma, :mrf, policies`
              * `config :pleroma, :instance, mrf_transparency` is now `config :pleroma, :mrf, transparency`
              * `config :pleroma, :instance, mrf_transparency_exclusions` is now `config :pleroma, :mrf, transparency_exclusions`
              """)
end

added 1 commit

• 31ebdf92 - moving mrf settings from instance to separate group

Compare with previous version

added 1 commit

• 4a711d12 - moving mrf settings from instance to separate group

Compare with previous version

LGTM.

Please make this a reusable function we can use for later namespace moves:

def move_namespace_and_warn(namespace_map, warning_preface)

that can be later called like this:

  def check_old_mrf_config do
    move_namespace_and_warn([
        {[:instance, :rewrite_policy], [:mrf, :policies]},
        {[:instance, :mrf_transparency], [:mrf, :transparency]},
        {[:instance, :mrf_transparency_exclusions], [:mrf, :transparency_exclusions]}
      ], """
         !!!DEPRECATION WARNING!!!
         Your config is using old namespaces for MRF configuration. They should work for now, but you are advised to change to new namespaces to prevent possible issues later:
        """)
  end

added 9 commits

• 4a711d12...fbf02a37 - 8 commits from branch develop
• 584d6181 - moving mrf settings from instance to separate group

Compare with previous version

added 208 commits

• 584d6181...dd4d10b2 - 207 commits from branch develop
• 8a70e748 - moving mrf settings from instance to separate group

Compare with previous version

added 58 commits

• 8a70e748...7ee35eb9 - 57 commits from branch develop
• 0490abaf - moving mrf settings from instance to separate group

Compare with previous version

changed milestone to %2.1

added 269 commits

• 0490abaf...0dd863f8 - 268 commits from branch develop
• 0b25e3dd - moving mrf settings from instance to separate group

Compare with previous version

added 45 commits

• 0b25e3dd...09563545 - 44 commits from branch develop
• db531ce0 - moving mrf settings from instance to separate group

Compare with previous version

added 61 commits

• db531ce0...07e7c80b - 60 commits from branch develop
• 03e57625 - moving mrf settings from instance to separate group

Compare with previous version

added 147 commits

• 03e57625...c74018e6 - 146 commits from branch develop
• 7af2c112 - moving mrf settings from instance to separate group

Compare with previous version

added 74 commits

• 7af2c112...aeacfb24 - 73 commits from branch develop
• 470d4150 - moving mrf settings from instance to separate group

Compare with previous version

added 567 commits

• 470d4150...8bfacffa - 566 commits from branch develop
• ed189568 - moving mrf settings from instance to separate group

Compare with previous version

added 1 commit

• b66e6eb5 - fixes for tests

Compare with previous version

I think it would be more readable to have it be done in one step like: :instance, rewrite_policy moved to :mrf, policies, how you did in the deprecation messages could be just copy-pasted there.

Done

added 1 commit

• abda3f2d - suggestion for changelog

Compare with previous version

added 1 commit

• 9a82de21 - formatting

Compare with previous version