Refactor notification settings

I still need a migration to replace the currently saved user settings to the new ones

mentioned in merge request pleroma-fe!1124 (merged)

added 1 commit

4c82f657 - Formatting

Compare with previous version

added 1 commit

d4b20c96 - Migrate old notification settings to new variants

Compare with previous version

changed the description

Migration included. The disused non_follows field will be automatically removed the next time the user saves their notification settings with a change.

Wouldn't this need some kind of hint for the frontend?

How would an alternative front-end know if the old or new version were in place?

The old version wasn't even documented correctly as it was still the docs from the very original implementation, so I'm not sure if there's any other FE that tried to implement the settings other than maybe yours? This isn't really something that feels like a feature-flag we should expose in /api/v1/instance or nodeinfo, so I guess alternative FEs would have to sniff the Pleroma BE version.

It's not a good situation or conducive to supporting third-party FEs by not having a sane/stable interface here, which is something I hope we can finally solve. Suggestions welcome!