Simple policy reasons for instance specific policies

Closes #1850 (closed)

• Deprectate strings for SimplePolicy
  • Give warning when strings detected
  • When strings detected, rewrite config
• All mrfSimple should work with tuples and not with strings any more (strings have been rewritten during the deprecation test, see previous point)
• Same for quarentine settings
  • Deprecate and rewrite settings with strings
  • Make it work with tuples instead of strings
• Same for transparency_exclusions
  • Deprecate and rewrite settings with strings
  • Make it work with tuples instead of strings
• Change in the docs (at the very least the cheatsheet, but check for other occurrences as well) and changelog
  • SimplePolicy
  • quarentine
  • transparency_exclusions
• Write DB migrations (see old branch priv/repo/migrations/20200913125549_simple_policy_string_to_tuple.exs)
  • SimplePolicy
  • quarentine
  • transparency_exclusions
• change config/description.exs so all changed settings use tuples
  • SimplePolicy
  • quarentine
  • transparency_exclusions
• Change what nodeinfo returns without breaking backwards compatibility
  • SimplePolicy
  • quarentine

MR's for FE's

• Pleroma-fe should be ready to be merged when this MR is merged
  • MR to admin-fe: admin-fe!187 (merged)
• Admin-fe is ready but still needs review
  • MR to pleroma-fe: pleroma-fe!1263 (merged)

changed the description

Did you try adding mrf_simple into @full_subkey_update of lib/pleroma/config/config_db.ex ?

And IIRC AdminFE has some hardcoded stuff in it :/

ping @linafilippova

added 1 commit

• ae417fba - add to full_subkey_update

Compare with previous version

Hey @ilja! From what I see some changes need to be made in Admin-FE as well. Updating the type of the setting to {:list, :tuple} is not enough because several settings that have this type has to be treated differently so that we can add an unlimited number of value pairs. :replace and in your case :reject are among those settings.

key and value are default placeholders for that input, you can also change that on the frontend.

In the near future, we've planned to add a new type for such settings so there would be no need to hardcode the settings' keys. But for now you'll have to at least add the key here: https://git.pleroma.social/pleroma/admin-fe/-/blob/develop/src/store/modules/normalizers.js#L69. I agree that we can improve on that, so if you open an issue in admin-fe I will take care of it after back end changes in description.exs are ready.

Hey @linafilippova , It took me a while, but I'm finally ready 🎉 I've been able to figure out the changes needed in the admin-fe and made an MR admin-fe!187 (merged)

The admin-fe with my changes still works on an older pleroma, but not the other way around so it's probably best to have the admin-fe merged first.

changed title from WIP [Need help] Simple policy reasons for instance specific policies to WIP Simple policy reasons for instance specific policies

changed the description

changed the description

added 1 commit

• 2eac0415 - Allow tuples instead of strings for SimplePolicy

Compare with previous version

marked the checklist item Make sure there backwards compatibility for people who have strings in these settings as completed

added 1 commit

• c11f8028 - make remove_avatar also a tuple in admin-fe

Compare with previous version

marked the checklist item Also change config/description.exs so admin-fe can use tuples as completed

marked the checklist item Make all instance lists in Simple Policy accept tuples as completed

added 1 commit

• 5a6df219 - Always return tuples to nodeinfo

Compare with previous version

marked the checklist item Always return tuples to nodeinfo as completed

changed the description

changed the description

added 1 commit

• 1fff6cd1 - Add migration

Compare with previous version

added 1 commit

• b8259954 - Add migration

Compare with previous version

marked the checklist item Write a migration for the DB settings as completed