Add `idempotency_key` to the chat message entity
Closes #2126 (closed)
Complementary FE MR pleroma-fe!1228 (merged)
(Alternatively, we can create and use a separate key, e.g., client_message_id
to separate the concern a bit.)
Merge request reports
Activity
mentioned in merge request pleroma-fe!1228 (merged)
- Resolved by feld
Could we have some asserts about the presence of the idempotency key in the responses? Otherwise LGTM
added 1 commit
- 69fd32ec - Add `idempotency_key` to the chat_message entity.
added 53 commits
-
69fd32ec...e02101e1 - 52 commits from branch
pleroma:develop
- a0b5ed3a - Add `idempotency_key` to the chat_message entity.
-
69fd32ec...e02101e1 - 52 commits from branch
Updated it to include the
idempotency_key
in theGET /api/v1/pleroma/chats/:id/messages
response as well. When the streaming is disabled, FE can sometimes receive the polling response between the DB insert and the HTTP message sending response, which can also lead to creation of duplicates on FE unless the identifier is provided.added 1 commit
- a3f67d61 - Add `idempotency_key` to the chat_message entity.
added 94 commits
-
a3f67d61...f9ece1a7 - 93 commits from branch
pleroma:develop
- 108e9c28 - Add `idempotency_key` to the chat_message entity.
-
a3f67d61...f9ece1a7 - 93 commits from branch
added 114 commits
-
108e9c28...b48724af - 113 commits from branch
pleroma:develop
- 22ede934 - Add `idempotency_key` to the chat_message entity.
-
108e9c28...b48724af - 113 commits from branch
added 62 commits
-
22ede934...2fd384e0 - 61 commits from branch
pleroma:develop
- a4e87b55 - Add `idempotency_key` to the chat_message entity.
-
22ede934...2fd384e0 - 61 commits from branch
- Resolved by feld
Sorry for not commenting earlier, I don't like that this is stored in the database / validated. I'd rather put it in something like cachex for a minutes.
added 11 commits
-
a4e87b55...2f740180 - 9 commits from branch
pleroma:develop
- 724656f6 - Add `idempotency_key` to the chat_message entity.
- a27e7c75 - Use cache to store the idempotency key for chat messages.
-
a4e87b55...2f740180 - 9 commits from branch
added 1 commit
- 1ebbb654 - Use cache to store the idempotency key for chat messages.
added 1 commit
- 0be79991 - Use cache to store the idempotency key for chat messages.
added 1 commit
- 42374672 - Use cache to store the idempotency key for chat messages.
added 1 commit
- 3c82d558 - Use cache to store the idempotency key for chat messages.
added 1 commit
- 53a37b44 - Use cache to store the idempotency key for chat messages.
added 60 commits
-
53a37b44...4fbdd1c8 - 58 commits from branch
pleroma:develop
- b51a7406 - Add `idempotency_key` to the chat_message entity.
- 74cf6616 - Use cache to store the idempotency key for chat messages.
-
53a37b44...4fbdd1c8 - 58 commits from branch
added 1 commit
- 8e41baff - Add idempotency_key to the chat_message entity.
mentioned in commit 37e8e8bf