Skip to content

Fix duplicate inbox deliveries

mint requested to merge (removed):fix-duplicate-inbox-deliveries into develop

The issues has been extensively documented here, but the gist of it is that due to the fact that determine_inbox function went unused in !4004 (merged), the server started repeatedly delivering the same activities to each user-specific inbox, causing DoS on large servers with users that have lots of followers. This MR reuses said function.


  • Adding a changelog: In the changelog.d directory, create a file named <code>.<type>.

    <code> can be anything, but we recommend using a more or less unique identifier to avoid collisions, such as the branch name.

    <type> can be add, change, remove, fix, security or skip. skip is only used if there is no user-visible change in the MR (for example, only editing comments in the code). Otherwise, choose a type that corresponds to your change.

    In the file, write the changelog entry. For example, if an MR adds group functionality, we can create a file named group.add and write Add group functionality in it.

    If one changelog entry is not enough, you may add more. But that might mean you can split it into two MRs. Only use more than one changelog entry if you really need to (for example, when one change in the code fix two different bugs, or when refactoring).

Merge request reports