Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pleroma pleroma
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 646
    • Issues 646
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 89
    • Merge requests 89
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PleromaPleroma
  • pleromapleroma
  • Merge requests
  • !455

Reset http security settings to fix plug test

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged h3poteto requested to merge h3poteto/pleroma:fix/test into develop Nov 16, 2018
  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 1

Now, sometimes a test is failed; like https://git.pleroma.social/normandy/pleroma/-/jobs/9602

  1) test referrer-policy header reflects configured value (Pleroma.Web.Plugs.HTTPSecurityPlugTest)
     test/plugs/http_security_plug_test.exs:62
     Assertion with == failed
     code:  assert Conn.get_resp_header(conn, "referrer-policy") == ["same-origin"]
     left:  []
     right: ["same-origin"]
     stacktrace:
       test/plugs/http_security_plug_test.exs:67: (test)

So I fixed http_security_plug_test.

Now the order of tests is random, so sometimes Config.put([:http_security, :enabled], false) runs before referrer-policy header reflects configured value. So I reset this setting before test referrer.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/test