pleroma-elixir-libraries/elixir-captcha
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity

Port build to elixir_make #10

Closed
phnt wants to merge 1 commit from gitlab-mr-iid-9 into master
pull from: gitlab-mr-iid-9
merge into: pleroma-elixir-libraries:master
Conversation 3 Commits 1 Files changed 2 +9 -33
phnt commented 2024-10-30 23:42:21 +00:00
Member
Copy link

Fixes build issue on OpenBSD. Previous solution hardcoded "make" which
on OpenBSD doesn't support the Makefile.

Minimum Elixir version bumped to the same as elixir_make.

  • Tested with:
    • Elixir 1.17.2/OTP 26 - OpenBSD 7.6
    • Elixir 1.14.5/OTP 23 - Arch Linux
Fixes build issue on OpenBSD. Previous solution hardcoded "make" which on OpenBSD doesn't support the Makefile. Minimum Elixir version bumped to the same as elixir_make. * Tested with: - Elixir 1.17.2/OTP 26 - OpenBSD 7.6 - Elixir 1.14.5/OTP 23 - Arch Linux
lanodan commented 2024-11-27 22:26:03 +00:00
Owner
Copy link

I guess that's to effectively use gmake in the end?

What about https://git.pleroma.social/pleroma/elixir-libraries/elixir-captcha/-/merge_requests/10 instead?

I guess that's to effectively use `gmake` in the end? What about https://git.pleroma.social/pleroma/elixir-libraries/elixir-captcha/-/merge_requests/10 instead?
phnt commented 2024-11-28 17:11:23 +00:00
Author
Member
Copy link

Correct.

Making it posix compatible guards against the case where the elixir-make OS auto-detection breaks, which is better in the long run. I've tested it on the three supported BSD variants and it does work.

Other than that, I don't have a preference over one or the other.

Correct. Making it posix compatible guards against the case where the `elixir-make` OS auto-detection breaks, which is better in the long run. I've tested it on the three supported BSD variants and it does work. Other than that, I don't have a preference over one or the other.
lanodan commented 2024-11-28 21:07:46 +00:00
Owner
Copy link

Closing in favor of https://git.pleroma.social/pleroma/elixir-libraries/elixir-captcha/-/merge_requests/10

Closing in favor of https://git.pleroma.social/pleroma/elixir-libraries/elixir-captcha/-/merge_requests/10

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma-elixir-libraries/elixir-captcha!10
No description provided.