pleroma-elixir-libraries/elixir-captcha
1
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix warnings on modern Elixir #8

Closed
feld wants to merge 0 commits from gitlab-mr-iid-7 into master
pull from: gitlab-mr-iid-7
merge into: pleroma-elixir-libraries:master
Conversation 2 Commits - Files changed -
feld commented 2024-06-27 16:05:39 +00:00
Owner
Copy link
No description provided.
feld commented 2024-06-27 16:12:20 +00:00
Author
Owner
Copy link

Pipeline is failing because we have mix test --cover as our default test job and we aren't at 90% test coverage which is kinda silly because there's only 1 public function in this entire module

Pipeline is failing because we have `mix test --cover` as our default test job and we aren't at 90% test coverage which is kinda silly because there's only 1 public function in this entire module
feld commented 2024-06-27 16:40:03 +00:00
Author
Owner
Copy link

If the priv/captcha binary does not exist we raise an error, so the :error return will never happen.

I'm not aware of the captcha binary ever failing to return valid data.

We can just cheat and make it pass with 100% coverage with this ugly pipeline:

  def get() do
    Application.app_dir(:captcha, "priv/captcha")
    |> System.cmd([])
    |> (fn {<<text::bytes-size(5), img::binary>>, 0} ->
          {:ok, text, img}
        end).()
  end
If the `priv/captcha` binary does not exist we raise an error, so the :error return will never happen. I'm not aware of the `captcha` binary ever failing to return valid data. We can just cheat and make it pass with 100% coverage with this ugly pipeline: ``` def get() do Application.app_dir(:captcha, "priv/captcha") |> System.cmd([]) |> (fn {<<text::bytes-size(5), img::binary>>, 0} -> {:ok, text, img} end).() end ```

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma-elixir-libraries/elixir-captcha!8
No description provided.