Fix thread rendering when there is a reply to a non-existing parent #153

Closed

eugenijm wants to merge 0 commits from gitlab-mr-iid-40 into master

eugenijm commented

2020-10-08 22:25:44 +00:00

Member

Re: https://git.pleroma.social/pleroma/fedi-fe/-/issues/3

Fix thread rendering when there is a reply to a non-existing parent.

Statuses without valid inReplyToId become replies to the first status in the thread.

Example:

(Edit: Maybe we can also add some kind of visual indicator to give users a hint that this is a reply to a non-existing status)

Before the "3" status is deleted:

After the "3" status is deleted:

(Edit: maybe it would better to create a "dummy" post with the placeholder avatar, nickname and the "Deleted" content and nest the replies so it looks more like an actual post that was deleted. Edit2: implemented that)

Without the indicator:

Re: https://git.pleroma.social/pleroma/fedi-fe/-/issues/3 Fix thread rendering when there is a reply to a non-existing parent. Statuses without valid `inReplyToId` become replies to the first status in the thread. Example: (Edit: Maybe we can also add some kind of visual indicator to give users a hint that this is a reply to a non-existing status) Before the "3" status is deleted: ![Screen_Shot_2020-10-09_at_1.22.28_AM](/attachments/c03df6d7-35b5-447f-a355-1d591e8caed9) After the "3" status is deleted: (Edit: maybe it would better to create a "dummy" post with the placeholder avatar, nickname and the "Deleted" content and nest the replies so it looks more like an actual post that was deleted. Edit2: implemented that) ![Screen_Shot_2020-10-13_at_4.03.45_PM](/attachments/94420293-10bc-49d9-8429-c583df14842b) Without the indicator: ![Screen_Shot_2020-10-09_at_1.23.46_AM](/attachments/f86428b6-455c-4ddd-8a2b-02ec8e32f3f9)

Screen_Shot_2020-10-09_at_1.23.46_AM.png

292 KiB

Screen_Shot_2020-10-09_at_1.22.28_AM.png

298 KiB

Screen_Shot_2020-10-13_at_4.03.45_PM.png

335 KiB