Pruned objects prevent deletion of remote users #1204

Closed
opened 2019-08-20 00:03:30 +00:00 by gidi · 3 comments
Member

It looks like pruning (old, public, non-local) objects removes the rows from the objects table but leaves the activities that refer to them. I believe the idea is that the objects can be re-fetched anyway. On 1.0.6 I observe that this blocks deletion of remote users because of a failure in normalizing the activity.

If I have a whole lot of remote users from evil.site that I want to delete, I do not want to normalize the activities and re-fetch all those objects from evil.site, which I can't anyway because it is now blocked. I want the users, their activities and their objects to be gone.

It seems that the code goes through a determination whether ActivityPub messages need to be sent about the activities to be deleted. I don't think that's relevant for remote users, unless I'm mistaken.

I don't know whether this issue exists on develop as well, but I didn't see recent changes that seemed related.

It looks like pruning (old, public, non-local) objects removes the rows from the objects table but leaves the activities that refer to them. I believe the idea is that the objects can be re-fetched anyway. On 1.0.6 I observe that this blocks deletion of remote users because of a failure in normalizing the activity. If I have a whole lot of remote users from evil.site that I want to delete, I do not want to normalize the activities and re-fetch all those objects from evil.site, which I can't anyway because it is now blocked. I want the users, their activities and their objects to be gone. It seems that the code goes through a determination whether ActivityPub messages need to be sent about the activities to be deleted. I don't think that's relevant for remote users, unless I'm mistaken. I don't know whether this issue exists on develop as well, but I didn't see recent changes that seemed related.
Author
Member

Further more. deleting remote users sends out Delete user post messages to all kinds of servers. I'll stop experimenting with this now...

Further more. deleting remote users sends out Delete ~~user~~ post messages to all kinds of servers. I'll stop experimenting with this now...

We fixed the issue that sends out local deletes for remote objects. I'll have to check out the pruning.

We fixed the issue that sends out local deletes for remote objects. I'll have to check out the pruning.

The pruned object will indeed prevent deletion. Checking for ways to fix this.

The pruned object will indeed prevent deletion. Checking for ways to fix this.
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma#1204
No description provided.