pleroma/pleroma
3
2
Fork 3
Code Issues 773 Pull requests 83 Projects Releases 1 Packages Wiki Activity

Fix a migration wiping user info of users that don't have any mutes #5235

Closed
rinpatch wants to merge 3 commits from gitlab-mr-iid-1856 into gitlab-mr-base-iid-1856
pull from: gitlab-mr-iid-1856
merge into: pleroma:gitlab-mr-base-iid-1856
Conversation 6 Commits 3 Files changed 8 +50 -9
rinpatch commented 2019-10-18 11:14:02 +00:00
Member
Copy link

And introduce safe_jsonb_set

Closes #1324

And introduce safe_jsonb_set Closes #1324
lambadalambda commented 2019-10-18 11:16:00 +00:00
Owner
Copy link

raising will make the queyr error, right?

raising will make the queyr error, right?
lambadalambda commented 2019-10-18 11:16:30 +00:00
Owner
Copy link

Very nice, but can you add a test for the new function?

Very nice, but can you add a test for the new function?
rinpatch commented 2019-10-18 11:17:01 +00:00
Author
Member
Copy link

Yes, it will abort the current transaction

Yes, it will abort the current transaction
rinpatch commented 2019-10-18 11:17:10 +00:00
Author
Member
Copy link

Yeah, will do

Yeah, will do
lambadalambda commented 2019-10-18 11:45:29 +00:00
Owner
Copy link

So if this raises, is there no error reported?

So if this raises, is there no error reported?
rinpatch commented 2019-10-18 11:52:26 +00:00
Author
Member
Copy link

This doesn't raise. jsonb_set wipes the column when you try to set the value to NULL, safe_jsonb_set has a coalesce which will call jsonb_set with 'null'::jsonb if asked to set the value to NULL. It raises only when jsonb_set wiped the column and we didn't expect it to, because I am not confident enough that this was the only jsonb_set bug.

This doesn't raise. `jsonb_set` wipes the column when you try to set the value to `NULL`, `safe_jsonb_set` has a `coalesce` which will call `jsonb_set` with `'null'::jsonb` if asked to set the value to `NULL`. It raises only when `jsonb_set` wiped the column and we didn't expect it to, because I am not confident enough that this was the only `jsonb_set` bug.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AP C2S

   
AdminAPI

   
Breaking API

Affects clients

  
Breaks existing config

   
Check if still valid

   
Data Protection

   
Do not merge

   
Document in the changelog

   
Doing

   
Feature Request / Enhancement

   
MastoAPI

   
NL2

Improved Mobile Experience

  
NL4

Improved instance customization and QoL options

  
OStatus

   
OTP Releases

   
Refactor

   
Security

   
To Do

   
TwitterAPI

   
bug

   
complicated

   
confirmed

   
deps

   
discussion

   
documentation

   
easy

   
feature: to be merged in stable

   
fix: to be merged in stable

   
incident

Denotes a disruption to IT services and the associated issues require immediate attention

  
needs to be backported to maint

   
needs-changes

   
needs-info

   
needs-review

   
performance

   
regression

   
unclear
No labels
AP C2S
AdminAPI
Breaking API
Breaks existing config
Check if still valid
Data Protection
Do not merge
Document in the changelog
Doing
Feature Request / Enhancement
MastoAPI
NL2
NL4
OStatus
OTP Releases
Refactor
Security
To Do
TwitterAPI
bug
complicated
confirmed
deps
discussion
documentation
easy
feature: to be merged in stable
fix: to be merged in stable
incident
needs to be backported to maint
needs-changes
needs-info
needs-review
performance
regression
unclear
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/pleroma!5235
No description provided.