pleroma/fedi-fe
0
0
Fork 0
Code Issues 47 Pull requests 2 Projects Releases Packages Wiki Activity

Media captions #142

Closed
marypelletier wants to merge 0 commits from gitlab-mr-iid-29 into master
pull from: gitlab-mr-iid-29
merge into: pleroma:master
Conversation 4 Commits - Files changed -
marypelletier commented 2020-10-01 16:42:01 +00:00
Member
Copy link

Closes #45

Screen_Shot_2020-10-01_at_12.39.20_PM

Screen_Shot_2020-10-01_at_12.39.28_PM

Closes #45 ![Screen_Shot_2020-10-01_at_12.39.20_PM](/attachments/dfe8f9dd-3723-4855-9359-ce58cb00f5b0) ![Screen_Shot_2020-10-01_at_12.39.28_PM](/attachments/64112161-7e8a-479c-8e2b-cd387256c9b1)
Screen_Shot_2020-10-01_at_12.39.20_PM.png
1 MiB
Screen_Shot_2020-10-01_at_12.39.28_PM.png
354 KiB
marypelletier commented 2020-10-01 16:43:02 +00:00
Author
Member
Copy link

@patcoll this is just static text for now

@patcoll this is just static text for now
marypelletier commented 2020-10-01 16:44:38 +00:00
Author
Member
Copy link

@patcoll this should only have the class status-gallery__slide__media--with-caption if a caption exists

@patcoll this should only have the class `status-gallery__slide__media--with-caption` if a caption exists
patcoll commented 2020-10-01 21:21:14 +00:00
Member
Copy link

Previewable at: https://5f764530e296040007da04e7--gifted-kalam-43b5bf.netlify.app/feeds/all

Previewable at: https://5f764530e296040007da04e7--gifted-kalam-43b5bf.netlify.app/feeds/all
MarisaCam commented 2020-10-02 15:23:27 +00:00
Member
Copy link

Screen_Shot_2020-10-02_at_11.19.08_AM

Verified that captions are displaying correct for FF/Chrome/Safari

![Screen_Shot_2020-10-02_at_11.19.08_AM](/attachments/88dd2f90-5c4a-4d3c-bedc-ff47b3e46891) Verified that captions are displaying correct for FF/Chrome/Safari
Screen_Shot_2020-10-02_at_11.19.08_AM.png
2.6 MiB

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Doing

   
In Review

   
Ready for QA
No labels
Doing
In Review
Ready for QA
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pleroma/fedi-fe!142
No description provided.