pleroma/pleroma
pleroma/pleroma
Watch
3
6
Fork
You've already forked pleroma
 17
Code Issues 359 Pull requests 64 Projects Releases 1 Packages 13 Wiki Activity

Revert "Merge branch 'object-creation' into 'develop'" #4196

Closed
lambadalambda wants to merge 0 commits from gitlab-mr-iid-810 into develop
pull from: gitlab-mr-iid-810
merge into: pleroma:develop
Conversation 1 Commits - Files changed -
lambadalambda commented 2019-02-11 08:08:06 +00:00
Owner
Copy link

This reverts merge request #4188

I suspect it leads to double-inserted create activities.

This reverts merge request #4188 I suspect it leads to double-inserted create activities.
lambadalambda commented 2019-02-11 08:09:19 +00:00
Author
Owner
Copy link
Feb 10 22:16:25 neckbeard mix[22796]: 22:16:25.775 request_id=2m13le3pm308knoe1k00064h [info] Converted error Ecto.MultipleResultsError to 500 response
Feb 10 22:16:25 neckbeard mix[22796]: 22:16:25.775 request_id=2m13le3pm308knoe1k00064h [info] Sent 500 in 16ms
Feb 10 22:16:25 neckbeard mix[22796]: 22:16:25.777 [error] #PID<0.2325.0> running Pleroma.Web.Endpoint (cowboy_protocol) terminated
Feb 10 22:16:25 neckbeard mix[22796]: Server: neckbeard.xyz:80 (http)
Feb 10 22:16:25 neckbeard mix[22796]: Request: GET /api/statuses/friends_timeline.json?count=20
Feb 10 22:16:25 neckbeard mix[22796]: ** (exit) an exception was raised:
Feb 10 22:16:25 neckbeard mix[22796]:     ** (Ecto.MultipleResultsError) expected at most one result but got 2 in query:
Feb 10 22:16:25 neckbeard mix[22796]: from a in Pleroma.Activity,
Feb 10 22:16:25 neckbeard mix[22796]:   where: fragment("coalesce((?)->'object'->>'id', (?)->>'object') = ?", a.data, a.data, ^"https://welovela.in/objects/65364c2e-c6fd-4a16-8666-8b013c2d3ae8"),
Feb 10 22:16:25 neckbeard mix[22796]:   where: fragment("(?)->>'type' = 'Create'", a.data)
Feb 10 22:16:25 neckbeard mix[22796]:         (ecto) lib/ecto/repo/queryable.ex:73: Ecto.Repo.Queryable.one/4
Feb 10 22:16:25 neckbeard mix[22796]:         (pleroma) lib/pleroma/web/activity_pub/activity_pub.ex:910: Pleroma.Web.ActivityPub.ActivityPub.entire_thread_visible_for_user?/2
Feb 10 22:16:25 neckbeard mix[22796]:         (elixir) lib/enum.ex:2934: Enum.filter_list/2
Feb 10 22:16:25 neckbeard mix[22796]:         (elixir) lib/enum.ex:2935: Enum.filter_list/2
Feb 10 22:16:25 neckbeard mix[22796]:         (pleroma) lib/pleroma/web/twitter_api/twitter_api_controller.ex:102: Pleroma.Web.TwitterAPI.Controller.friends_timeline/2
Feb 10 22:16:25 neckbeard mix[22796]:         (pleroma) lib/pleroma/web/twitter_api/twitter_api_controller.ex:5: Pleroma.Web.TwitterAPI.Controller.action/2
Feb 10 22:16:25 neckbeard mix[22796]:         (pleroma) lib/pleroma/web/twitter_api/twitter_api_controller.ex:5: Pleroma.Web.TwitterAPI.Controller.phoenix_controller_pipeline/2
Feb 10 22:16:25 neckbeard mix[22796]:         (pleroma) lib/pleroma/web/endpoint.ex:5: Pleroma.Web.Endpoint.instrument/4```
```Feb 10 22:16:25 neckbeard mix[22796]: 22:16:25.758 request_id=2m13le3pm308knoe1k00064h [info] GET /api/statuses/friends_timeline.json Feb 10 22:16:25 neckbeard mix[22796]: 22:16:25.775 request_id=2m13le3pm308knoe1k00064h [info] Converted error Ecto.MultipleResultsError to 500 response Feb 10 22:16:25 neckbeard mix[22796]: 22:16:25.775 request_id=2m13le3pm308knoe1k00064h [info] Sent 500 in 16ms Feb 10 22:16:25 neckbeard mix[22796]: 22:16:25.777 [error] #PID<0.2325.0> running Pleroma.Web.Endpoint (cowboy_protocol) terminated Feb 10 22:16:25 neckbeard mix[22796]: Server: neckbeard.xyz:80 (http) Feb 10 22:16:25 neckbeard mix[22796]: Request: GET /api/statuses/friends_timeline.json?count=20 Feb 10 22:16:25 neckbeard mix[22796]: ** (exit) an exception was raised: Feb 10 22:16:25 neckbeard mix[22796]: ** (Ecto.MultipleResultsError) expected at most one result but got 2 in query: Feb 10 22:16:25 neckbeard mix[22796]: from a in Pleroma.Activity, Feb 10 22:16:25 neckbeard mix[22796]: where: fragment("coalesce((?)->'object'->>'id', (?)->>'object') = ?", a.data, a.data, ^"https://welovela.in/objects/65364c2e-c6fd-4a16-8666-8b013c2d3ae8"), Feb 10 22:16:25 neckbeard mix[22796]: where: fragment("(?)->>'type' = 'Create'", a.data) Feb 10 22:16:25 neckbeard mix[22796]: (ecto) lib/ecto/repo/queryable.ex:73: Ecto.Repo.Queryable.one/4 Feb 10 22:16:25 neckbeard mix[22796]: (pleroma) lib/pleroma/web/activity_pub/activity_pub.ex:910: Pleroma.Web.ActivityPub.ActivityPub.entire_thread_visible_for_user?/2 Feb 10 22:16:25 neckbeard mix[22796]: (elixir) lib/enum.ex:2934: Enum.filter_list/2 Feb 10 22:16:25 neckbeard mix[22796]: (elixir) lib/enum.ex:2935: Enum.filter_list/2 Feb 10 22:16:25 neckbeard mix[22796]: (pleroma) lib/pleroma/web/twitter_api/twitter_api_controller.ex:102: Pleroma.Web.TwitterAPI.Controller.friends_timeline/2 Feb 10 22:16:25 neckbeard mix[22796]: (pleroma) lib/pleroma/web/twitter_api/twitter_api_controller.ex:5: Pleroma.Web.TwitterAPI.Controller.action/2 Feb 10 22:16:25 neckbeard mix[22796]: (pleroma) lib/pleroma/web/twitter_api/twitter_api_controller.ex:5: Pleroma.Web.TwitterAPI.Controller.phoenix_controller_pipeline/2 Feb 10 22:16:25 neckbeard mix[22796]: (pleroma) lib/pleroma/web/endpoint.ex:5: Pleroma.Web.Endpoint.instrument/4```

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
AP C2S

   
AdminAPI

   
Breaking API
Affects clients

  
Breaks existing config

   
Check if still valid

   
Data Protection

   
Do not merge

   
Document in the changelog

   
Doing

   
Feature Request / Enhancement

   
MastoAPI

   
NL2
Improved Mobile Experience

  
NL4
Improved instance customization and QoL options

  
OStatus

   
OTP Releases

   
Refactor

   
Security

   
To Do

   
TwitterAPI

   
bug

   
complicated

   
confirmed

   
deps

   
discussion

   
documentation

   
easy

   
feature: to be merged in stable

   
fix: to be merged in stable

   
incident
Denotes a disruption to IT services and the associated issues require immediate attention

  
needs to be backported to maint

   
needs-changes

   
needs-info

   
needs-review

   
performance

   
regression

   
unclear
No labels
AP C2S
AdminAPI
Breaking API
Breaks existing config
Check if still valid
Data Protection
Do not merge
Document in the changelog
Doing
Feature Request / Enhancement
MastoAPI
NL2
NL4
OStatus
OTP Releases
Refactor
Security
To Do
TwitterAPI
bug
complicated
confirmed
deps
discussion
documentation
easy
feature: to be merged in stable
fix: to be merged in stable
incident
needs to be backported to maint
needs-changes
needs-info
needs-review
performance
regression
unclear
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
pleroma/pleroma!4196
No description provided.